Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin bar: add subitems to the top-left WP.com icon menu #42099

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Feb 27, 2025

Related to:

Proposed changes:

This PR adds the following to the top-left WordPress(.com) icon in the admin bar:

Simple Atomic
image image
  • Brought back the menu items on hover.
  • Add Sites and Domains items pointing to the global view.
  • On Atomic, Brought back Core's About WordPress and Get Involved menu.
    • On Simple sites, those links are not valid / hidden by opers.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Patch this PR
  2. Verify the changes in the WP icon as described above.

Copy link
Contributor

github-actions bot commented Feb 27, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 27, 2025
Copy link
Contributor

github-actions bot commented Feb 27, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the untangle-admin-bar-2 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin untangle-admin-bar-2

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@fushar fushar force-pushed the untangle-admin-bar-2 branch from cb22245 to b3adf81 Compare February 27, 2025 10:33
Copy link

jp-launch-control bot commented Feb 27, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-bar/wpcom-admin-bar.php 0/180 (0.00%) 0.00% 34 💔

Full summary · PHP report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@fushar fushar force-pushed the untangle-admin-bar-2 branch from b3adf81 to ae63892 Compare February 28, 2025 02:54
@fushar fushar changed the title Admin bar: make top-left icon behave closer to Core Admin bar: make top-left WP icon behave closer to Core Feb 28, 2025
@fushar fushar added I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. and removed [Status] In Progress labels Feb 28, 2025
@fushar fushar marked this pull request as ready for review February 28, 2025 02:57
@fushar fushar requested a review from a team February 28, 2025 02:58
@fushar fushar changed the title Admin bar: make top-left WP icon behave closer to Core Admin bar: add subitems to the top-left WP.com icon menu Feb 28, 2025
@fushar fushar force-pushed the untangle-admin-bar-2 branch from ae63892 to 4e407a7 Compare February 28, 2025 04:19
Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected both on Simple & Atomic ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [mu wpcom Feature] Wpcom Admin Bar [Package] Jetpack mu wpcom WordPress.com Features [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants