Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social | Move publicize/scheduled-actions endpoints from WPCOM #42136

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Feb 28, 2025

We are bringing scheduled resharing to wp-admin - pdrWKz-1XL-p2, thus we need to move the scheduled action endpoint to publicize package.

Proposed changes:

  • Moves publicize/scheduled-actions to publicize package
  • Updates the endpoints to correctly use the rest base paths - publicize/scheduled-actions/post instead of post/publicize/scheduled-actions

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pdrWKz-1XL-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Follow the instructions given in Social | Update the scheduled-actions endpoint wp-calypso#100624
  • Schedule some shares for a Jetpack site using the above instructions
  • Apply 175318-ghe-Automattic/wpcom to your sandbox
  • Apply this PR to your sandbox on top of the above PR
  • Point the public API and your site to your sandbox
  • Goto Social admin page for the site
  • Enter this in the browser console
await wp.apiFetch({
    path: 'wpcom/v2/publicize/scheduled-actions'
});
  • Confirm that the request is successful and lists the scheduled shares for the site
  • Try getting scheduled shares for a post
await wp.apiFetch({
    path: 'wpcom/v2/publicize/scheduled-actions/posts/:post_id'
});
  • Confirm that it works fine
  • Try deleting one
await wp.apiFetch({
    path: 'wpcom/v2/publicize/scheduled-actions/posts/:post_id/:action_id',
    method: 'DELETE'
});

Confirm that it works fine

@manzoorwanijk manzoorwanijk added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Feb 28, 2025
@manzoorwanijk manzoorwanijk requested a review from a team February 28, 2025 09:21
@manzoorwanijk manzoorwanijk self-assigned this Feb 28, 2025
@github-actions github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize labels Feb 28, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Contributor

github-actions bot commented Feb 28, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the social/move-scheduled-action-endpoints-from-wpcom branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack social/move-scheduled-action-endpoints-from-wpcom

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link

jp-launch-control bot commented Feb 28, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/publicize/src/class-publicize-setup.php 0/43 (0.00%) 0.00% 1 ❤️‍🩹

1 file is newly checked for coverage.

File Coverage
projects/packages/publicize/src/rest-api/class-scheduled-actions-controller.php 66/261 (25.29%) ❤️‍🩹

Full summary · PHP report · JS report

@manzoorwanijk
Copy link
Member Author

Static analysis needs the stubs which I have updated in 175320-ghe-Automattic/wpcom and should be fine after #42137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Status] Needs Team Review Obsolete. Use Needs Review instead. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant