-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable compiled bindings #321
Conversation
Building on top of this comment. Should we avoid enabling by default here? |
I've been trying to get an app updated from Avalonia 11 preview 4 and the related lib versions to the latest versions of things, with compiled bindings and trimming enabled, and AvaloniaEdit appears to be working there (though i'm not using completions). Are compiled bindings supposed to be disabled at the top of CompletionList.xaml ? |
I tested the demo app, and the CompletionList works fine. |
I mean I don't know the consequences of enabling compiled bindings in AvaloniaEdit project. What do you think @Gillibald ? |
Enabling compiled bindings by default isn't affecting consuming projects so it should be fine. It is always good to be able to avoid reflection bindings if possible. |
Make completion list trimming compatible.