Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compiled bindings #321

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Enable compiled bindings #321

merged 6 commits into from
Apr 6, 2023

Conversation

hez2010
Copy link
Contributor

@hez2010 hez2010 commented Apr 2, 2023

Make completion list trimming compatible.

@danipen
Copy link
Collaborator

danipen commented Apr 2, 2023

Building on top of this comment.
AvaloniaUI/Avalonia#10880 (comment)

Should we avoid enabling by default here?

@Numpsy
Copy link

Numpsy commented Apr 2, 2023

I've been trying to get an app updated from Avalonia 11 preview 4 and the related lib versions to the latest versions of things, with compiled bindings and trimming enabled, and AvaloniaEdit appears to be working there (though i'm not using completions).

Are compiled bindings supposed to be disabled at the top of CompletionList.xaml ?

@hez2010
Copy link
Contributor Author

hez2010 commented Apr 3, 2023

I tested the demo app, and the CompletionList works fine.

@danipen
Copy link
Collaborator

danipen commented Apr 3, 2023

I mean I don't know the consequences of enabling compiled bindings in AvaloniaEdit project. What do you think @Gillibald ?

@danipen
Copy link
Collaborator

danipen commented Apr 6, 2023

@Gillibald
Copy link
Contributor

Enabling compiled bindings by default isn't affecting consuming projects so it should be fine. It is always good to be able to avoid reflection bindings if possible.

@danipen danipen merged commit daf4320 into AvaloniaUI:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants