Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change name popper.js-1.14.3 to popper-core-1.14.3 #453

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

mangelft
Copy link
Contributor

The update_thirdparty.sh fails because the name of the library popper.js-1.14.3 has changed to popper-core-1.14.3

@codecov-io
Copy link

Codecov Report

Merging #453 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   11.85%   11.87%   +0.01%     
==========================================
  Files          74       74              
  Lines        7505     7505              
==========================================
+ Hits          890      891       +1     
+ Misses       6615     6614       -1
Impacted Files Coverage Δ
bin/packages/Import_helper.py 87.03% <0%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77d16f...b5beb89. Read the comment docs.

@Terrtia Terrtia merged commit 6bf9bc3 into CIRCL:master Jan 20, 2020
@Terrtia
Copy link
Member

Terrtia commented Jan 20, 2020

Hi @mangelft !
Good catch, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants