Switch from pyroute2 to pyroute2.core #239
Conversation
Only IPRoute in pyroute2.core is used is used by assemblyline see: https://github.com/svinota/pyroute2/discussions/786 and https://github.com/svinota/pyroute2/discussions/796
cccs-jh
requested review from
cccs-sgaron,
cccs-douglass,
cccs-kevin,
cccs-aa and
cccs-rs
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 64.94% 65.22% +0.27%
==========================================
Files 119 119
Lines 10412 10412
==========================================
+ Hits 6762 6791 +29
+ Misses 3650 3621 -29
Continue to review full report at Codecov.
|
This will be merged after #240 is tested |
I can confirm that Frankenstrings is not erroring in staging with the base in the dev branch. @cccs-jh can you confirm as well? https://github.com/CybercentreCanada/assemblyline-base/releases/tag/v4.0.1.dev85 |
The newest pyroute2 version is split into separate packages. See https://github.com/svinota/pyroute2/discussions/786 and https://github.com/svinota/pyroute2/discussions/796.
Assemblyline only uses IPRoute from pyroute2.core. Currently the pyroute2 and pyroute2-minimal meta packages have import bugs related to not having importlib-metadata installed on python3.7 svinota/pyroute2#797. This is causing an error in Frankenstrings which uses functions in net.py to validate network strings. This is fixed by switching to pyroute2.core which doesn't use importlib-metadata and minimizes our dependencies.