Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bugs in regular expressions and code logic (DEV) #269

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

cccs-kevin
Copy link
Contributor

@cccs-kevin cccs-kevin commented Jun 9, 2021

Closes https://cccs.atlassian.net/browse/AL-1245

Please please please review this carefully, and suggestions are welcome!

@cccs-kevin cccs-kevin changed the base branch from master to dev June 9, 2021 19:45
@cccs-kevin cccs-kevin changed the title Fixing bugs in reuglar expressions and code logic Fixing bugs in reuglar expressions and code logic (DEV) Jun 9, 2021
@cccs-kevin cccs-kevin changed the title Fixing bugs in reuglar expressions and code logic (DEV) Fixing bugs in regular expressions and code logic (DEV) Jun 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #269 (b114fe3) into dev (da73b0e) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #269      +/-   ##
==========================================
+ Coverage   67.03%   67.32%   +0.29%     
==========================================
  Files         119      119              
  Lines       10419    10472      +53     
==========================================
+ Hits         6984     7050      +66     
+ Misses       3435     3422      -13     
Impacted Files Coverage Δ
assemblyline/common/constants.py 87.50% <ø> (ø)
assemblyline/common/identify.py 90.74% <100.00%> (+2.46%) ⬆️
assemblyline/odm/models/tagging.py 100.00% <0.00%> (ø)
assemblyline/odm/randomizer.py 96.05% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da73b0e...b114fe3. Read the comment docs.

Copy link
Contributor

@cccs-jh cccs-jh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cccs-kevin cccs-kevin merged commit 5132077 into dev Jun 10, 2021
@cccs-kevin cccs-kevin deleted the identify_bugs branch June 10, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants