-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use batched NSRL insertion #58
Conversation
Pipeline seems to be broken:
There is no public access to those repos. |
Correct, although if the PR is ready for review, I think I should be able to trigger the pipeline manually for testing |
An alternative to using Just in the interest of minimizing our footprint if we can 😅 |
I do agree with that stance, pandas might not be the best library for this work. I'll try and make a port. |
Could we respecify the ticket ? Reverting commit da56c7f should suffice as the issue is in the indefinitely growing |
Patch should be included in the latest release! 🚀 |
With the current NSRL insertion implementation of the update server, the server needs to load the entire NSRL database in memory. This can make the service crash if not enough RAM is available.
Using pandas, it is possible to load
n
lines of a CSV file using a generator, which will save a lot of memory.