sdkman in container #1301
Merged
sdkman in container #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Subramanian <[email protected]>
prabhu
commented
Aug 8, 2024
| @@ -98,9 +100,6 @@ RUN set -e; \ | |||
| && sdk install maven $MAVEN_VERSION \ | |||
| && sdk install gradle $GRADLE_VERSION \ | |||
| && sdk install sbt $SBT_VERSION \ | |||
| && sdk offline enable \ | |||
There was a problem hiding this comment.
These are breaking changes that also alter the threat model, since we are essentially unlocking and making the sdk command available for cdxgen and other tools.
prabhu
commented
Aug 8, 2024
| MAVEN_HOME="/opt/maven/${MAVEN_VERSION}" \ | ||
| GRADLE_HOME="/opt/gradle/${GRADLE_VERSION}" \ | ||
| SBT_HOME="/opt/sbt/${SBT_VERSION}" \ | ||
| JAVA_HOME="/root/.sdkman/candidates/java/${JAVA_VERSION}" \ |
There was a problem hiding this comment.
Possibly breaking change.
prabhu
commented
Aug 8, 2024
| @@ -72,9 +74,6 @@ RUN set -e; \ | |||
| && sdk install maven $MAVEN_VERSION \ | |||
| && sdk install gradle $GRADLE_VERSION \ | |||
| && sdk install sbt $SBT_VERSION \ | |||
| && sdk offline enable \ | |||
There was a problem hiding this comment.
I don't think sdkman supports ppc64 that well, so the new java with version types feature are unlikely to work well in this architecture.
prabhu
commented
Aug 8, 2024
| export GRADLE_VERSION=8.8 | ||
| export MAVEN_HOME="/opt/maven/${MAVEN_VERSION}" | ||
| export GRADLE_HOME="/opt/gradle/${GRADLE_VERSION}" | ||
| export SBT_HOME="/opt/sbt/${SBT_VERSION}" | ||
| export SDKMAN_DIR=/.sdkman |
There was a problem hiding this comment.
These needs to be tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-t java11 etc are supported in container invocations.