Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy BomUploadProcessingTask #3722

Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 16, 2024

Description

Removes the legacy BomUploadProcessingTask.

  • Makes the new implementation (previously known as BomUploadProcessingTaskV2) the default
  • Removes code related to the legacy implementation
  • Removes the experimental:bom.processing.task.v2.enabled property

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

* Makes the new implementation (previously known as `BomUploadProcessingTaskV2`) the default
* Removes code related to the legacy implementation
* Removes the `experimental:bom.processing.task.v2.enabled` property

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added this to the 4.12 milestone May 16, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.30% (target: -1.00%) 89.66% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (94a7378) 22015 16735 76.02%
Head commit (2d8769c) 21630 (-385) 16377 (-358) 75.71% (-0.30%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3722) 406 364 89.66%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro merged commit db58e69 into DependencyTrack:master May 16, 2024
12 checks passed
@nscuro nscuro deleted the remove-legacy-bomuploadprocessingtask branch May 16, 2024 15:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant