Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add support for serving from custom path #801

Merged
merged 8 commits into from
Jul 1, 2024
Merged

Feature: add support for serving from custom path #801

merged 8 commits into from
Jul 1, 2024
+37 −19

Conversation

Squixx
Copy link
Contributor

@Squixx Squixx commented Apr 3, 2024

Description

I want to run dependency track frontend on a path instead of /, but doing this currently would require to do a full rebuild of the frontend. This PR could be a possible solution direction.

I've seen the reference to:

 // Relative paths cannot be supported. Research by @nscur0 - https://owasp.slack.com/archives/CTC03GX9S/p1608400149085400
  publicPath: '/',

However I can not open this link, so am oblivious to any previous research

I'll update the docs once it's clear this is the way forward

Addressed Issue

DependencyTrack/dependency-track#1514

Additional Details

setting the BASE_HREF env variable allows you to set a path

Checklist

@Squixx Squixx changed the title Feat/urlpath Feature: add suport for serving from custom path Apr 3, 2024
@Squixx Squixx changed the title Feature: add suport for serving from custom path Feature: add support for serving from custom path Apr 3, 2024
Martijn van der Meij added 4 commits April 3, 2024 16:47
cfeat: poc for urlpath
1fec95e 
Signed-off-by: Martijn van der Meij <[email protected]>
feat: set base_href through env
7ca1a46 
Signed-off-by: Martijn van der Meij <[email protected]>
feat: set base_href through env
4ba0876 
Signed-off-by: Martijn van der Meij <[email protected]>
feat: update dockercompose
8f02e4c 
Signed-off-by: Martijn van der Meij <[email protected]>
@fnxpt
Copy link
Contributor

fnxpt commented Apr 23, 2024

similar to #23

@Squixx
Copy link
Contributor Author

Squixx commented Apr 23, 2024

similar to #23

Does that work with oidc? This pr also has working oidc, but I'd be happy if either could move forward

@nscuro nscuro self-assigned this Jun 18, 2024
@nscuro nscuro added the enhancement New feature or request label Jun 18, 2024
@nscuro nscuro added this to the 4.12 milestone Jun 18, 2024
@nscuro
Copy link
Member

nscuro commented Jun 18, 2024

Sorry for the long wait @Squixx, I'll have a look at this next and have assigned it to v4.12.

nscuro
nscuro reviewed Jun 30, 2024
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again sorry for the delay! Overall this looks good to me.

Just a minor nitpick about naming of the env var.

Also, it would be good to add a few words about how to configure this in the docs: https://github.com/DependencyTrack/dependency-track/blob/master/docs/_docs/getting-started/configuration.md#frontend

@Squixx Squixx mentioned this pull request Jul 1, 2024
Merged
5 tasks
@Squixx
Copy link
Contributor Author

Squixx commented Jul 1, 2024

Again sorry for the delay! Overall this looks good to me.

Just a minor nitpick about naming of the env var.

Also, it would be good to add a few words about how to configure this in the docs: https://github.com/DependencyTrack/dependency-track/blob/master/docs/_docs/getting-started/configuration.md#frontend

added docs in DependencyTrack/dependency-track#3899

@nscuro nscuro merged commit b1298a8 into DependencyTrack:master Jul 1, 2024
10 checks passed
This was referenced Sep 22, 2024
Closed
Closed
@rissson rissson mentioned this pull request Oct 14, 2024
Merged
1 task
nscuro added a commit to DependencyTrack/hyades-frontend that referenced this pull request Dec 5, 2024
@nscuro
Add support for serving from custom path
61bedb3 
Ports DependencyTrack/frontend#801

Co-authored-by: Martijn van der Meij <[email protected]>
Signed-off-by: nscuro <[email protected]>
This was referenced Dec 5, 2024
Merged
Open
nscuro added a commit to DependencyTrack/hyades-frontend that referenced this pull request Dec 5, 2024
@nscuro
Add support for serving from custom path
6cbb845 
Ports DependencyTrack/frontend#801

Co-authored-by: Martijn van der Meij <[email protected]>
Signed-off-by: nscuro <[email protected]>
nscuro added a commit to DependencyTrack/hyades-frontend that referenced this pull request Jan 27, 2025
@nscuro
Add support for serving from custom path
6bf0722 
Ports DependencyTrack/frontend#801

Co-authored-by: Martijn van der Meij <[email protected]>
Signed-off-by: nscuro <[email protected]>

# Conflicts:
#	docker/etc/nginx/templates/default.conf.template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees

@nscuro nscuro

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.12
Development

Successfully merging this pull request may close these issues.
4 participants
@Squixx @fnxpt @nscuro @vandermeij-martijn