Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure prettier to sort JSON files #58

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jun 14, 2024

Description

Configures prettier to sort JSON files.

This is to maintain consistent ordering of (primarily) the i18n files. Makes it easier to read diffs, and discover existing fields.

Addressed Issue

N/A

Additional Details

Formatting is performed with the usual npm run prettier-fix command.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended

This is to maintain consistent ordering of (primarily) the i18n files. Makes it easier to read diffs, and discover existing fields.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added enhancement New feature or request dx Issues related to developer experience (DX) labels Jun 14, 2024
@nscuro nscuro added this to the 5.5.0 milestone Jun 14, 2024
nscuro added a commit to nscuro/dependency-track-frontend that referenced this pull request Jun 14, 2024
This is to maintain consistent ordering of (primarily) the i18n files. Makes it easier to read diffs, and discover existing fields.

Backport of DependencyTrack/hyades-frontend#58

Signed-off-by: nscuro <[email protected]>
Copy link
Collaborator

@sahibamittal sahibamittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@sahibamittal sahibamittal merged commit 007e530 into rebase-v4.11.3 Jun 18, 2024
3 checks passed
@sahibamittal sahibamittal deleted the json-sorting branch June 18, 2024 14:30
netomi pushed a commit to netomi/frontend that referenced this pull request Aug 8, 2024
This is to maintain consistent ordering of (primarily) the i18n files. Makes it easier to read diffs, and discover existing fields.

Backport of DependencyTrack/hyades-frontend#58

Signed-off-by: nscuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Issues related to developer experience (DX) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants