feat: add focus styles #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feerzlay
force-pushed
the
feature/switch-base-focus
branch
2 times, most recently
from
866583f to
9d7919a
Compare
feerzlay
requested changes
Oct 16, 2024
| @@ -114,6 +115,10 @@ const CheckboxRoot = styled(SwitchBase, { | |||
| height: '24px !important', | |||
| width: '24px !important', | |||
| }, | |||
|
|
|||
| [`&:not(.${buttonBaseClasses.disabled}):focus-visible`]: { | |||
| outlineOffset: '-4px', | |||
There was a problem hiding this comment.
Похоже эти стили не применяются, потому что фокусируется не сама кнопка, а инпут внутри нее. В SwitchBase это идет как &:not(:disabled):has(:focus-visible).
ElizabethT7
force-pushed
the
feature/switch-base-focus
branch
from
9d7919a to
928c84f
Compare
feerzlay
force-pushed
the
master
branch
2 times, most recently
from
8fb8e68 to
f12d8ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.