Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discogs provider #238

Merged
merged 4 commits into from
Mar 3, 2024
Merged

Discogs provider #238

merged 4 commits into from
Mar 3, 2024

Conversation

pwarren
Copy link
Contributor

@pwarren pwarren commented Feb 28, 2024

Implemented a Discogs lookup provider, have scanned in 30 of my CDs to test. Hope this is of assistance :)

@pwarren
Copy link
Contributor Author

pwarren commented Feb 28, 2024

Have now scanned in >120 CDs, has been exactly what I wanted. Next up, my Movies and Books!

@Forceu
Copy link
Owner

Forceu commented Mar 2, 2024

Thanks, I will have a look at it tomorrow and probably merge it!

@Forceu
Copy link
Owner

Forceu commented Mar 3, 2024

According to the Discogs API documentation, no API key is needed. Is there a reason, why an API key field is in the menu?

@pwarren
Copy link
Contributor Author

pwarren commented Mar 3, 2024

I think there are some endpoints that didn't require a token, but the search API does:

curl -s https://api.discogs.com/database/search?q=731344422424 | jq
{
  "message": "You must authenticate to access this resource."
}
curl -s "https://api.discogs.com/database/search?q=731344422424&token=$MYTOKEN" | jq .results[0].title
"Cherry Poppin' Daddies - Ferociously Stoned"

@pwarren
Copy link
Contributor Author

pwarren commented Mar 3, 2024

And I did not get consistent results when using the /search?barcode= endpoint, which also requires auth

@Forceu
Copy link
Owner

Forceu commented Mar 3, 2024

Ah got it. Thanks!

@Forceu Forceu merged commit 854da32 into Forceu:master Mar 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants