Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note regarding WSL to UsersShellConfigs #430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add note regarding WSL to UsersShellConfigs #430

wants to merge 1 commit into from

Conversation

Karneades
Copy link
Contributor

Add note for WSL because otherwise it can't be found. Filtered in GRR for "WSL", "Linux", "Subsystem", ... found nothing. At least a note for WSL must be there.

I was searching again for WSL, didn't find anything in the artifacts and then searched through the Github repo for WSL. Found my own contribution (haha). We already worte in the PR about if we should make a note about WSL in the artifact... today, I run into that again. Was already making a new one...

Also, inside GRR I looked first only for Windows artifacts, then switched to all. As I wrote in the PR #385 I would move that to Windows because I search there for the WSL part and not in the Unix part.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #430 (d573c48) into main (2723924) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files           7        7           
  Lines         446      446           
=======================================
  Hits          410      410           
  Misses         36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2723924...d573c48. Read the comment docs.

@joachimmetz
Copy link
Member

@Karneades thx for the suggested changes. Must have missed your comments on #385.

Could a WSL label help here? Though it does not look like GRR allows to filter on labels.

Adding WSL to supported_os might be more involved for GRR

@Karneades
Copy link
Contributor Author

I currently don't know how to best make it "foundable" in GRR and be enough generic for the repo. supported_os is incorrect for me because it's not an own OS. Add a label seems a good way.

@joachimmetz
Copy link
Member

@Karneades the definitions now support aliases (GRR not yet) but that might be a more suitable solution for the use case you describe.

@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Work cannot progress until another issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants