-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature: Generic Sensor-based motion sensors #4204
Conversation
@Fyrd, I'm a bit puzzled by this error:
If I add a key for 64
Something obvious I've overlooked? I see other features use a similar structure, i.e. only define one key for |
Adding new browser versions via JSON isn't supported: |
- Add Accelerometer - Add Gyroscope - Add Magnetometer - Add Orientation Sensor
Thanks! |
@Fyrd, I notice this PR was merged (thanks!), and the site content was updated in the following data update: 4fa442c In this data update the following files were added:
I noticed https://caniuse.com/#feat=orientation-sensor Here is further data that should help you flip the Cross-browser test suites for all these features:
Respective test results on Chrome 67 for Android (CA) and Chrome 67 for Desktop (CD):
In addition, for manual testing we have developed a tool that complements the automated cross-browser test suite: Please let me know if you have any questions or if I can be of further help. |
Hi @anssiko, thanks for all the links and information. I notice when I run those tests on either of my Mac laptops they mostly fail, is that expected (due to missing sensors in the device)? Also even on Chrome 67 for Android I notice a simple test of |
@Fyrd, correct, your Mac does not have the supporting sensor hardware. Some (older!) models do. Magnetometer is available by enabling the ”Generic Sensor Extra Classes” experimental flag in |
Ah, that explains things, thanks. Should all upcoming versions of Chrome not also use |
Okay, all features are now on the site. Thanks again! |
Fix #2778
Fix #2777
Fix #2776