Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touchegg crashes on some gestures #341

Closed
vimpostor opened this issue Sep 28, 2020 · 2 comments
Closed

touchegg crashes on some gestures #341

vimpostor opened this issue Sep 28, 2020 · 2 comments
Milestone

Comments

@vimpostor
Copy link
Contributor

vimpostor commented Sep 28, 2020

I use the default configuration. Some gestures work fine (e.g. the minimize gesture, by swiping down with 3 fingers). Some others always make touchegg crash, like e.g. MAXIMIZE_RESTORE_WINDOW, which is configured on swiping up with 3 fingers.

Here is the crash log:

Successfully connected to Touchégg daemon
Gesture begin detected
        Gesture information:
                Fingers: 3
                Type: SWIPE
                Direction: UP
        Gesture performed on app: konsole
        Action configured for this gesture
        Starting action
X Error of failed request:  BadRRCrtc (invalid Crtc parameter)
  Major opcode of failed request:  140 (RANDR)
  Minor opcode of failed request:  20 (RRGetCrtcInfo)
  Crtc id in failed request: 0x0
  Serial number of failed request:  46
  Current serial number in output stream:  46

I have to mention that I use a laptop with an external monitor attached, while having the internal laptop display disabled, which might be a very weird setup.

I use Arch Linux with KDE(X11) 5.19.5 and Xorg 1.20.9.

Any idea what might be going wrong?
If you need any other output, feel free to contact me.

Edit: I just tested with only the internal laptop display on and the external monitor disconnected, and now everything is working.
I don't really need the gestures so much, when I have the external monitor connected, but if this is an easy fix, that would still be cool. :)

@JoseExposito
Copy link
Owner

Hi!

First of all, thanks for the bug report!

You are right, it crashes because it is not able to figure out the screen the animation should be displayed on.

It is a bit of an edge case, but I'll try to fix it.
Could you attach the output of the xrandr command when the external monitor is connected and the laptop screen is disconnected please?

@vimpostor
Copy link
Contributor Author

vimpostor commented Sep 29, 2020 via email

vimpostor added a commit to vimpostor/touchegg that referenced this issue Sep 29, 2020
If a monitor is disabled via KDE settings, it will still have
output->connection == RR_Connected.
The following XRRGetCrtcInfo would then fail and crash the program.

Instead we now also check for a valid CRTC before we proceed with making
that call.
Fixes JoseExposito#341.
JoseExposito added a commit that referenced this issue Sep 30, 2020
Fix #341: Fix crash when one of the screens is disabled
@JoseExposito JoseExposito added this to the 2.0.2 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants