Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FluentAssertions from 7.0.0 to 8.0.0 #270

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 14, 2025

Bumps FluentAssertions from 7.0.0 to 8.0.0.

Release notes

Sourced from FluentAssertions's releases.

8.0.0

What's Changed

License change

Breaking Changes

New features

Improvements

... (truncated)

Commits
  • 901c8fa Merge pull request #2947 from fluentassertions/release-8.0
  • df7e9bf Update ownership and license
  • 65d78e2 Merge pull request #2945 from fluentassertions/main
  • bfbf509 Update landing page (#2944)
  • f77fe32 Bump the xunit group with 3 updates
  • 266fede Bump Microsoft.Testing.Extensions.TrxReport from 1.5.0 to 1.5.1
  • e5283d0 Bump Meziantou.Analyzer from 2.0.184 to 2.0.186
  • 3d8f03f Fix several link texts
  • 7426493 Fix release note PR-link
  • bcc974b Simplify FirstOrDefault() + null check to Any()
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 7.0.0 to 8.0.0.
- [Release notes](https://github.com/fluentassertions/fluentassertions/releases)
- [Changelog](https://github.com/fluentassertions/fluentassertions/blob/develop/AcceptApiChanges.ps1)
- [Commits](fluentassertions/fluentassertions@7.0.0...8.0.0)

---
updated-dependencies:
- dependency-name: FluentAssertions
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Jan 14, 2025
@frasten
Copy link

frasten commented Jan 16, 2025

Is it a good idea to update to v8.0.0? They’ve changed their license, and now you have to pay $130 per year per developer.
Perhaps it’s better to pin the version and freeze it at v7.0.0.

@JoshKeegan
Copy link
Owner

Lucky CI fails then, or I'd have merged this!

Thanks for letting me know, I'll review their new license before doing anything with this. It won't work for us if anyone who needs to work on xRetry needs a paid license.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 21, 2025

Superseded by #271.

@dependabot dependabot bot closed this Jan 21, 2025
@dependabot dependabot bot deleted the dependabot/nuget/FluentAssertions-8.0.0 branch January 21, 2025 17:15
@JoshKeegan
Copy link
Owner

I think we'd be ok to use the newer versions of FluentAssertions, since their new licence alows non-commercial use for free and use by open source projects is explicitly listed as one such case. However, the same non-commercial use section also says:

The Software is not being used by or for an organisation, group of persons, legal entity, or company, that charges fees or earns revenues with or without the intention to make profit.

If I'm reading that correctly, that would conflict with the open-source provision should anyone need/want to contribute to xRetry, but do so on behalf of a company.

Since my initial reading of the license is that it contradicts itself in this case, and I'm not a lawyer, I think it's best to avoid upgrading. Their intention seems to be to allow use in open-source softare, but there's also no pressing reason for us to upgrade beyond v7 and accept the new license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants