-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Quick Link for docker pull #42
Comments
Hi, |
Wow you have been very quick :-) this is very nice and looks very good. |
Hey hey, thx. Only copy to clipboard is ready, sha256 need some rework. Nope, copy to clopboard copy this |
I will say (but this is only my opinion), to keep the docker pull. The push is more likely used from continuous build or any other automated system. |
[feat #42] Add copy to clipboard for images with tag and add sha256
Hello, Is it possible to have a second icon or a toggle button to copy also the sha256 inside the command? This is useful for production environment, where Trusted Content is turned on. |
Hi, Hum... Or it can be a feature only for static docker-registry-ui with a specific env var ? So for these registries there will always be the sha256. I noticed something, to pull with trusted content, it needs the sha256 of the digest and not the sha256 of the image. The one I get is the sha256 of the image... :/ |
Indeed, I'm using the static image, with both REGISTRY_TITLE and REGISTRY_URL defined (like in my PR for the documentation). Oh this is quite disappointing for the digest. I weren't aware about that :-( I found that you have to use a http header when requesting the image: |
Okay, registry URL is now fixed. Question: Have you ever tried the trusted pull ? When you use it, is the tag of your image updated? $ docker pull alpine:latest@sha256:e1871801d30885a610511c867de0d6baca7ed4e6a2573d506bbec7fd3b03873f
sha256:e1871801d30885a610511c867de0d6baca7ed4e6a2573d506bbec7fd3b03873f: Pulling from library/alpine
ff3a5c916c92: Already exists
Digest: sha256:e1871801d30885a610511c867de0d6baca7ed4e6a2573d506bbec7fd3b03873f
Status: Downloaded newer image for alpine@sha256:e1871801d30885a610511c867de0d6baca7ed4e6a2573d506bbec7fd3b03873f
$ docker images --digests | grep alpine
REPOSITORY TAG DIGEST IMAGE ID CREATED SIZE
alpine <none> sha256:e1871801d30885a610511c867de0d6baca7ed4e6a2573d506bbec7fd3b03873f 3fd9065eaf02 5 months ago 4.15MB In my example, I pulled Thx for the link, I will read this a bit later. |
Well to be honest, I did not yet enforce the Content trust but this is on my roadmap. I know there are many issues still open in Docker here and here but it's a matter of time before a fix 🤞 . |
Ok, I leave this issue open the time that docker solve the problem :) |
Hi,
Following your remarks when I've submitted my PR, you asked me about improvements.
One feature I really appreciate in other registry frontend, is the generated link "docker pull registry/image:tag" which avoid me to type the long command myself.
But it will be very more helpful if you can add the @sha256.
For keeping the UI as light as now, you can just add a "copy to clipboard" icon.
What do you think?
The text was updated successfully, but these errors were encountered: