Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update traefik to v2.x #396

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

update traefik to v2.x #396

wants to merge 5 commits into from

Conversation

ycyin
Copy link

@ycyin ycyin commented Sep 18, 2024

Updated traefik example #380

This is the version I'm using on production

@Joxit
Copy link
Owner

Joxit commented Sep 21, 2024

Hi, thank you for your contribution 😄

I posted one comment in your PR

Copy link

@jnovack jnovack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not part of the team, just making suggestions.

memory: 8g
reservations:
cpus: '1'
memory: 2g
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION:

These limits and reservations are way to egregious for testing (even for some swarm productions)! I understand it's an example, but I feel we can be a little bit more responsible with examples.

Traefik v2 takes up ~40MB RAM idle, you don't need reserve 2G (it's not V3! HA!)

Suggested:

       limits:
          cpus: '2'
          memory: 4g
        reservations:
          cpus: '0.1'
          memory: 128MB

- --entryPoints.web.forwardedHeaders.insecure
# - --entryPoints.websecure.address=:443
environment:
- TZ=Asia/Shanghai
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION:

Again, make it neutral to the most amount of people. TZ=UTC would be neutral.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants