Complete operations with a failure if deserializing response fails #27
Conversation
| "Typesafe repository releases" at "https://repo.typesafe.com/typesafe/releases/" | ||
| "Typesafe repository releases" at "https://repo.typesafe.com/typesafe/releases/", | ||
| // using staging artifact until 2.13 release is ready: https://github.com/apache/logging-log4j-scala/pull/3 | ||
| "Apache staging repository" at "https://repository.apache.org/content/repositories/staging" |
There was a problem hiding this comment.
not sure how you want to handle this, but vimalaguti/logging-log4j-scala is gone so it can no longer pull in the log4jScala project above
|
Right, I don't think the failure is related to my change? Any way you can retrigger the build on travis? |
|
Already tried it this afternoon (in European time), a new build is running now, let's see if it helps this time :) |
|
Looks like the rebuild passed? But the status on the PR still says failed... |
|
You're right 🤦♂️ |
|
@dontgitit thanks! Will hopefully be able to publish a release this weekend (in case I forget about it, feel free to ping me :)) |
|
Sorry for the delay, just published 1.9.1. It should be available on Maven central pretty soon, already released the artifacts in Sonatype's Nexus :) |
Fixes #26
Requests would previously never complete if an exception was thrown by the deserializer