Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TRAMMING_SCREW_THREAD to 40 for Ender 3 Printers #873

Merged
merged 10 commits into from
Jan 11, 2023

Conversation

zanhecht
Copy link
Contributor

@zanhecht zanhecht commented Dec 31, 2022

Requirements

  • Filling out this template is required. Pull Requests without a clear description may be closed at the maintainers' discretion.

Description

Specify that the Ender 3 uses M4 bed screws.

Benefits

Provides correct values for screw size if the ASSISTED_TRAMMING option is enabled.

Related Issues

Updated version of #872, rebaselined to 2.1.x.

Change to 50mm offset from edge for tramming points to allow the points to be balanced while allowing for a 50mm NOZZLE_TO_PROBE_OFFSET.
@@ -1034,7 +1034,7 @@
#if ENABLED(ASSISTED_TRAMMING)

// Define positions for probe points.
#define TRAMMING_POINT_XY { { 20, 20 }, { 180, 20 }, { 180, 180 }, { 20, 180 } }
#define TRAMMING_POINT_XY { { 50, 50 }, { 185, 50 }, { 185, 185 }, { 50, 185 } }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since tramming points will depend on your probe type & placement relative to the nozzle, it's probably best to leave these as Marlin's defaults.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do want to tram where the screws are, if possible, so the default should probably go for those points, and then it can be adjusted for a probe that can't reach.

Copy link
Member

@thisiskeithb thisiskeithb Dec 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in #872 (comment)

Stock screw locations on Ender-3/5 beds are TRAMMING_POINT_XY { { 32.5, 32.5 }, { 202.5, 32.5 }, { 202.5, 202.5 }, { 32.5, 202.5 } }, but they may not be reachable depending on where the probe is located relative to the nozzle.

Ex: If your probe is to the left of the hotend, you may not be able to reach the screw heads on the right side of the bed or if your probe is to the right of the hotend, you may not be able to reach the screw heads on the left side of the bed.

It really depends on your probe/mount/probe offsets/x & y min & max positions.

@zanhecht zanhecht changed the title Rebase changes to 2.1.x. Add 50mm offset. Set TRAMMING_SCREW_THREAD to 40 for Ender 3 Printers Dec 31, 2022
@zanhecht
Copy link
Contributor Author

I'll leave the tramming points discussion for another time, and redefine this pull request to just changing the screw thread. I expanded it to all Ender 3 variants while I was at it.

@thinkyhead thinkyhead merged commit 2eaa01d into MarlinFirmware:import-2.1.x Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants