Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we introduce an extra role for collection wide variables? #286

Closed
widhalmt opened this issue Oct 11, 2023 · 2 comments · Fixed by #250
Closed

Should we introduce an extra role for collection wide variables? #286

widhalmt opened this issue Oct 11, 2023 · 2 comments · Fixed by #250
Labels
question Further information is requested
Milestone

Comments

@widhalmt
Copy link
Member

Like in https://stackoverflow.com/questions/67213727/ansible-collections-collection-level-variable we could build a role called elasticstack. This will only hold defaults/main.yml and README.md. All variables we use in all roles could be set there. So we had them in a central place to change and document. And we could get rid of those pesky linter messages about variable names not matching role names.

@widhalmt widhalmt added the question Further information is requested label Oct 11, 2023
@ivareri
Copy link
Contributor

ivareri commented Oct 24, 2023

My first thought was that you meant a new repo with just a single role, but you're thinking of an extra role in this repo?

I do think this seems like a clean solution. As long as it is the same repo it shouldn't add any extra burden on contributors and reviewers.

@widhalmt
Copy link
Member Author

Yes, I'm thinking of a role in this very repo. Like roles/elasticstack . And have all "global" variables in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants