add fail message to roles that are not available as oss version #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widhalmt
requested changes
Aug 8, 2024
There was a problem hiding this comment.
Please start products with a capital letter in messages. e.g. "Kibana" instead of kibana.
And please refer to the issue you're trying to fix by using "closing keywords". This has to be in the first description of the PR. When the PR is merged, the Issue is automatically closed.
e.g.
fixes #333
There are several ways of installing Python modules on a system. We can't make safe assumptions about the system where the collection is used. Possible problems: * Modules available via package manager can be too old * Python could be entirely managed via package manager and pip wouldn't break that * Pip could be installed in different ways This change will do the following: * Install `pip` via package manager if a new variable is set * Try to install modules via pip * If that fails because Python is managed via package manager, try installing them via package manager * One of the above methods should be successful but you still might end up with modules which are too old to work * If that's the case you can force the installation via pip and break the managed Python installation fixes #334
widhalmt
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent the a strange error message that is not easy to understand for the basic user I added a check that fails for specific roles when the release type and version are not available for the specific role.