Change type of dashboard variables from constant to custom #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And #18 |
martialblog
approved these changes
Jan 23, 2025
|
well, I did not until now and the import fails. Sorry |
|
I deducted 1 from your trust pool |
|
that's only fair |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Grafana 11.3 most of the dashboards broke, due to Grafana enforcing that constants are
actually constant ( o.O ) (ref: grafana/grafana#90635 ).
Since this was a breaking change but actually a bugfix, the dashboards in here should be
updated.
This PR changes the
typeof all dashboard variabels fromconstanttocustom.It should not change anything really on Grafana < 11.3 and in general just restore the
functionality on >= 11.3