Replace futures dependency with futures_util
#246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is sufficient, and the former pulls over a dozen additional unused dependencies. Closes: NLnetLabs#245
|
Thanks for the PR! Looking good! (Minor nit for future PRs: We update the Changelog after merging because there’s often wonky merge conflicts – and we also have the PR number then.) |
partim
added a commit
that referenced
this pull request
Dec 28, 2023
Bug fixes * Fixed various issues preventing building in a no-std environment. ([#247] by [@dzamlo], [#248] by [@reitermarkus]) Other changes * The `resolv` feature now depends on `futures_util` instead of `futures`, trimming unused dependencies from the dependency tree. ([#246] by [@WhyNotHugo])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter is sufficient, and the former pulls over a dozen additional unused dependencies.
Closes: #245