Fix EDNS middleware bugs #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximon18
added a commit
that referenced
this pull request
Aug 8, 2024
… fix-edns-middleware / PR #355.
ximon18
force-pushed
the
fix-edns-middleware
branch
from
283c7b6 to
cf027d2
Compare
ximon18
changed the base branch from
stelline-server-testing-changes
to
main
- Reply with FORMERR if an OPT RR cannot be parsed. - Don't reply with FORMERR if an edns-tcp-keepalive option is received via UDP, instead ignore it per RFC 7828 3.2.1. - Only reserve space for an edns-tcp-keepalive option for TCP requests, not UDP requests. - Always reserve space for an OPT RR in the response for any request that has an OPT RR, not just TCP requests. - Disable TCP client retries in Stelline server tests otherwise a connection abort causes a retry which violates the test expectation.
ximon18
force-pushed
the
fix-edns-middleware
branch
from
cf027d2 to
444eb22
Compare
Philip-NLnetLabs
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various EDNS middleware fixes and improved Stelline test: