Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing non-stringified objects in runner #2027

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

madhur-ob
Copy link
Collaborator

This allows us to use the Runner API as follows:

Earlier:

Parameter('targets', type=JSONType, default={'abcd': 123})
with Runner("jj.py").run(anchor_date=anchor_date_str, targets='{"US": 1}') as running:

^^notice how passing a string version of json in the runner API

Now:

Parameter('targets', type=JSONType, default={'abcd': 123})
with Runner("jj.py").run(anchor_date=anchor_date_str, targets={"US": 1}) as running:

^^notice how passing the json directly in the runner API

@romain-intel romain-intel merged commit f19d018 into Netflix:master Sep 13, 2024
26 checks passed
@madhur-ob madhur-ob deleted the pass-json-runner branch September 13, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants