fix: attach conda decorator in conda_base flow_init #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
reviewed
Sep 16, 2024
| # Important for extensions implementing custom virtual environments | ||
| from metaflow import decorators | ||
|
|
||
| decorators._attach_decorators(flow, ["conda"]) |
There was a problem hiding this comment.
do we need a symmetric change for pypi_base too? if not, can you add the reasoning as a code comment?
There was a problem hiding this comment.
pypi_base already does this for itself so no change needed on that side. I'll refine the above comment a bit to clarify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attach
condadecorator to steps in theconda_basedecorator when using it.This solves an issue where a virtual environment implemented in an extension does not append
condaas part of environment decospecs, but still needs to know whether a step needs to execute on conda due to the flow decorator.decorators._attach_decoratorsis a no-op for existing conda decorators on a step so this should not have adverse effects.