feature: basic support for incident.io in Argo Workflows #2245
+155
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
reviewed
Feb 4, 2025
metaflow/metaflow_config.py
Outdated
| # Incident.io | ||
| INCIDENT_IO_API_KEY = from_conf("INCIDENT_IO_API_KEY", None) | ||
| INCIDENT_IO_SUCCESS_SEVERITY_ID = from_conf("INCIDENT_IO_SUCCESS_SEVERITY_ID", None) | ||
| INCIDENT_IO_ERROR_SEVERITY_ID = from_conf("INCIDENT_IO_ERROR_SEVERITY_ID", None) |
There was a problem hiding this comment.
we dont provide any of these as config options today for slack - can we lift them to cli args?
savingoyal
reviewed
Feb 4, 2025
| "Notifications require specifying an incoming Slack webhook url via --notify-slack-webhook-url or " | ||
| "PagerDuty events v2 integration key via --notify-pager-duty-integration-key.\n If you would like to set up " | ||
| "Notifications require specifying an incoming Slack webhook url via --notify-slack-webhook-url, " | ||
| "PagerDuty events v2 integration key via --notify-pager-duty-integration-key or Incident.io integration API key via --notify-incident-io-api-key.\n If you would like to set up " |
savingoyal
reviewed
Feb 4, 2025
savingoyal
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds basic support for incident.io alerts through Argo Workflows