Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deployer issue #2261

Merged
merged 2 commits into from
Feb 11, 2025
Merged

fix: Deployer issue #2261

merged 2 commits into from
Feb 11, 2025

Conversation

saikonen
Copy link
Collaborator

@saikonen saikonen commented Feb 11, 2025

last release introduced an issue that broke the argo workflows/step functions deployer implementation. The cause is https://github.com/Netflix/metaflow/pull/2234/files#diff-5b4ba4c231c3ab3a8e1df579662e664605edf1b903b2299b0d75a7613ffca945R530-R535 as the Argo deployer relies on a hidden Click option to pass values.

minimal repro example:

from metaflow import Deployer

if __name__=="__main__":
    deployer = Deployer(flow_file="HelloFlow.py").argo_workflows()
    deployed_flow = deployer.create()

will result in an error

ValueError: Unknown argument: 'deployer_attribute_file', possible args are: authorize, generate_new_token, given_token, tags, user_namespace, only_json, max_workers, workflow_timeout, workflow_priority, auto_emit_argo_events, notify_on_error, notify_on_success, notify_slack_webhook_url, notify_pager_duty_integration_key, notify_incident_io_api_key, incident_io_success_severity_id, incident_io_error_severity_id, enable_heartbeat_daemon, enable_error_msg_capture

Alternatively we could revert the skipping of hidden options introduced in #2234

@saikonen saikonen changed the title fix: argo workflows deployer issue fix: Deployer issue Feb 11, 2025
@saikonen saikonen merged commit 5133611 into master Feb 11, 2025
29 checks passed
@saikonen saikonen deleted the fix/argo-workflows-deployer branch February 11, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant