Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Argo notifications issues #2285

Merged
merged 3 commits into from
Feb 20, 2025
Merged

fix: Argo notifications issues #2285

merged 3 commits into from
Feb 20, 2025

Conversation

saikonen
Copy link
Collaborator

fixes issues with argo workflows nontifications that were uncovered by the recent incident.io feature.

  • change slack and pagerduty CLI option defaults to None instead of empty string
  • make sure that unrelated notification templates are not appended to the workflow template. Previously f.ex. slack notification templates were appended even when only configuring pagerduty.
  • adds incident.io to the notification annotations

@saikonen saikonen requested a review from savingoyal February 20, 2025 19:11
@savingoyal savingoyal merged commit c5925a2 into master Feb 20, 2025
29 checks passed
@savingoyal savingoyal deleted the fix/argo-notifications-issues branch February 20, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savingoyal savingoyal Awaiting requested review from savingoyal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikonen @savingoyal