Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local kubernetes setup #2292

Merged
merged 27 commits into from
Feb 25, 2025
Merged

local kubernetes setup #2292

merged 27 commits into from
Feb 25, 2025

Conversation

savingoyal
Copy link
Collaborator

@savingoyal savingoyal commented Feb 24, 2025

build wheel -

python setup.py sdist bdist_wheel

install resulting wheel -

python -m pip install --force-reinstall dist/...whl

deploy using

metaflow-dev up

tear down using

metaflow-dev down

use using

metaflow-dev shell

access UI using

metaflow-dev ui

Copy link

@josephsirak josephsirak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting pretty close.

  • There are a couple of indentation issues plus a couple of configuration issues

  • The other main feedback I have is on the services picker . I believe minio shouldn't be optional similar to postgres. I know that there is a use case for running just the metadata-service, which only needs the postgres database, but for anyone who is trying to use the metaflow-ui or just run flows without adding additional wiring for the datastore so they use S3 or set the --datastore=local flag, they will run into hard to debug issues if they didn't chose to install minio. Also, the metaflow-ui has an explicit dependency on it.

Makefile Outdated
"$$user_shell" -i; \
else \
env METAFLOW_HOME="$(PWD)/.devtools" \
METAFLOW_PROFILE=local \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got an error with make shell when trying to run a flow

metaflow.exception.MetaflowException: Unable to locate METAFLOW_PROFILE 'local' in '/.../metaflow/.devtools')

looks like the metaflow config file is stored as metaflow_config.json instead of config_local.json

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting - looks like some commits are missing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saikonen i believe your commits are missing

Tiltfile Outdated
)

#################################################
# ARGO EVENTS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like event publishing works, but I don't think this is wired up properly to trigger workflows when it receives events:

{"level":"error","ts":1740419561.4127948,"logger":"argo-events.eventbus-controller","caller":"sensor/controller.go:72","msg":"reconcile error","namespace":"default","senso
r":"demoforeachflow","error":"eventbus default not found","stacktrace":"github.com/argoproj/argo-events/pkg/reconciler/sensor.(*reconciler).Reconcile\n\t/home/runner/work/
argo-events/argo-events/pkg/reconciler/sensor/controller.go:72\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/home/runner/go/pkg/mod/s
igs.k8s.io/[email protected]/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/
home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controlle
r).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/inte
rnal/controller.(*Controller).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227"}

@savingoyal
Copy link
Collaborator Author

This is getting pretty close.

  • There are a couple of indentation issues plus a couple of configuration issues
  • The other main feedback I have is on the services picker . I believe minio shouldn't be optional similar to postgres. I know that there is a use case for running just the metadata-service, which only needs the postgres database, but for anyone who is trying to use the metaflow-ui or just run flows without adding additional wiring for the datastore so they use S3 or set the --datastore=local flag, they will run into hard to debug issues if they didn't chose to install minio. Also, the metaflow-ui has an explicit dependency on it.

thanks! re: minio being optional - the expectation is that more often than not, the user will choose the deploy everything (we can clarify that in services picker) - it's only the developers (and tests) who need to cherry pick.

@savingoyal savingoyal merged commit 8e38a51 into master Feb 25, 2025
37 checks passed
@savingoyal savingoyal deleted the savin/make branch February 25, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants