Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.terser: init at 5.7.1 #129668

Merged
merged 1 commit into from
Jul 9, 2021
Merged

nodePackages.terser: init at 5.7.1 #129668

merged 1 commit into from
Jul 9, 2021

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jul 8, 2021

Motivation for this change

Add terser, a maintained fork of uglify-es. Also update the nodePackages set in general.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 8, 2021
@SuperSandro2000
Copy link
Member

@talyz merge conflict

@talyz
Copy link
Contributor Author

talyz commented Jul 9, 2021

@SuperSandro2000 Updated!

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 9, 2021
@ofborg ofborg bot requested a review from midchildan July 9, 2021 07:52
@SuperSandro2000 SuperSandro2000 merged commit 5dbe52b into NixOS:master Jul 9, 2021
@talyz talyz deleted the terser branch July 9, 2021 12:04
@talyz
Copy link
Contributor Author

talyz commented Jul 10, 2021

Would it be possible to backport this to stable? What's the stance on backporting nodePackages changes?

@jyooru jyooru mentioned this pull request Dec 13, 2021
Closed
@Lord-Valen Lord-Valen mentioned this pull request Sep 13, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talyz @SuperSandro2000