Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.tailwindcss: init at 3.0.1 #149839

Merged
merged 1 commit into from
Dec 11, 2021
Merged

nodePackages.tailwindcss: init at 3.0.1 #149839

merged 1 commit into from
Dec 11, 2021

Conversation

jyooru
Copy link
Member

@jyooru jyooru commented Dec 9, 2021

Motivation for this change

Closes #149333

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jyooru
Copy link
Member Author

jyooru commented Dec 9, 2021

Running pkgs/development/node-packages/generate.sh seems to have also updated all the other node packages. I'm running nixpkgs-review on this PR now and I'm already seeing some failures due to the updates. Is there a way to add tailwindcss without updating all the other packages?

@jyooru jyooru changed the title tailwindcss: init at 2.2.19 nodePackages.tailwindcss: init at 2.2.19 Dec 9, 2021
@jyooru
Copy link
Member Author

jyooru commented Dec 9, 2021

Result of nixpkgs-review pr 149839 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • hyperspace-cli
  • teleprompter
  • timedoctor
8 packages failed to build:
  • python38Packages.batchspawner
  • python38Packages.dockerspawner
  • python38Packages.jupyterhub
  • python38Packages.jupyterhub-ldapauthenticator
  • python38Packages.jupyterhub-systemdspawner
  • python38Packages.jupyterhub-tmpauthenticator
  • python38Packages.oauthenticator
  • vscode-extensions.matklad.rust-analyzer
52 packages built:
  • antora
  • balanceofsatoshis
  • bat-extras.prettybat
  • bitwarden-cli
  • castnow
  • commitlint
  • create-cycle-app
  • deltachat-desktop
  • discourse
  • discourseAllPlugins
  • epgstation
  • fast-cli
  • flexoptix-app
  • gtop
  • iosevka
  • joplin
  • lumo
  • parity-ui
  • pm2
  • postcss-cli
  • pyright
  • python39Packages.batchspawner
  • python39Packages.dockerspawner
  • python39Packages.jupyterhub
  • python39Packages.jupyterhub-ldapauthenticator
  • python39Packages.jupyterhub-systemdspawner
  • python39Packages.jupyterhub-tmpauthenticator
  • python39Packages.oauthenticator
  • redoc-cli
  • shepherd
  • slack
  • sloc
  • teams
  • teck-programmer
  • thelounge
  • vimPlugins.coc-diagnostic
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-pyright
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-vetur
  • vscode
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.vadimcn.vscode-lldb
  • vscode-fhs
  • vscode-with-extensions
  • vscodium
  • vscodium-fhs
  • whalebird
  • yaml-language-server
  • zerobin
  • zx

@Mic92
Copy link
Member

Mic92 commented Dec 9, 2021

Sorry. I had to merge #149120 first to fix rust-analyzer

@jyooru
Copy link
Member Author

jyooru commented Dec 9, 2021

Sorry. I had to merge #149120 first to fix rust-analyzer

All good, I was trying to figure out if that fail was an issue of this PR!

@jyooru
Copy link
Member Author

jyooru commented Dec 10, 2021

Result of nixpkgs-review pr 149839 run on x86_64-linux 1

32 packages built:
  • balanceofsatoshis
  • bitwarden-cli
  • deltachat-desktop
  • epgstation
  • fast-cli
  • joplin
  • lumo
  • pm2
  • postcss-cli
  • pyright
  • python38Packages.batchspawner
  • python38Packages.dockerspawner
  • python38Packages.jupyterhub
  • python38Packages.jupyterhub-ldapauthenticator
  • python38Packages.jupyterhub-systemdspawner
  • python38Packages.jupyterhub-tmpauthenticator
  • python38Packages.oauthenticator
  • python39Packages.batchspawner
  • python39Packages.dockerspawner
  • python39Packages.jupyterhub
  • python39Packages.jupyterhub-ldapauthenticator
  • python39Packages.jupyterhub-systemdspawner
  • python39Packages.jupyterhub-tmpauthenticator
  • python39Packages.oauthenticator
  • redoc-cli
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-pyright
  • vimPlugins.coc-stylelint
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.vadimcn.vscode-lldb

@lobre
Copy link
Contributor

lobre commented Dec 10, 2021

There has just been an update from Tailwind to a major version today (v3.0.0). Maybe it is worth directly integrating it to avoid having to upgrade later?

https://www.npmjs.com/package/tailwindcss

@jyooru jyooru changed the title nodePackages.tailwindcss: init at 2.2.19 nodePackages.tailwindcss: init at 3.0.1 Dec 11, 2021
@Mic92 Mic92 merged commit f710129 into NixOS:master Dec 11, 2021
@jyooru jyooru deleted the init/tailwindcss branch December 11, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging request: tailwindcss cli
3 participants