Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/keepalived: add package option #346462

Merged
merged 1 commit into from
Dec 31, 2024
Merged

nixos/keepalived: add package option #346462

merged 1 commit into from
Dec 31, 2024

Conversation

itzwam
Copy link
Contributor

@itzwam itzwam commented Oct 4, 2024

Things done

support package option in keepalived module

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 4, 2024
@itzwam itzwam changed the title module/KeepAlived: Support pkg override without overlaying [PATCH] module/KeepAlived: Support pkg override without overlaying Oct 4, 2024
@itzwam itzwam marked this pull request as ready for review October 4, 2024 16:27
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 4, 2024
@itzwam itzwam force-pushed the feat/keepalivedPackage branch from 261f574 to b52732a Compare December 31, 2024 15:16
@itzwam
Copy link
Contributor Author

itzwam commented Dec 31, 2024

Accepted code-changes + rebased and squashed

@itzwam itzwam changed the title [PATCH] module/KeepAlived: Support pkg override without overlaying module/KeepAlived: Support pkg override without overlaying Dec 31, 2024
@FliegendeWurst FliegendeWurst changed the title module/KeepAlived: Support pkg override without overlaying nixos/keepalived: add package option Dec 31, 2024
@FliegendeWurst FliegendeWurst merged commit a2c878d into NixOS:master Dec 31, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itzwam @FliegendeWurst