Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OU-IMP] apriori: pos_cashback_warning renamed into pos_cashback #4763

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Feb 21, 2025

@legalsylvain legalsylvain added this to the 16.0 milestone Feb 21, 2025
@pedrobaeza
Copy link
Member

In fact, this is OU-ADD, as you are adding the "scripts" of a new module.

@legalsylvain
Copy link
Contributor Author

In fact, this is OU-ADD, as you are adding the "scripts" of a new module.

I don't remember where are explained that specific rules regarding openupgrade. Could you provide me the URL ? thanks !

@pedrobaeza
Copy link
Member

It's not put in any place yet, but the logic is this one:

  • [OU-ADD]: Add migrations scripts for a module.
  • [OU-FIX]: Fix existing migration scripts.
  • [OU-IMP]: Improve existing migration scripts, for example, adding some missing bits.
  • [OU-REM]: Remove migration scripts.

@MiquelRForgeFlow
Copy link
Contributor

@legalsylvain can you put here the link of the PR that made the module rename?

@legalsylvain legalsylvain force-pushed the 16.0-IMP-apriori-pos_cashback_warning-into-pos_cashback branch from c2d5ab9 to ad981bb Compare February 24, 2025 10:59
@legalsylvain
Copy link
Contributor Author

@MiquelRForgeFlow done.

@MiquelRForgeFlow
Copy link
Contributor

APP -> ADD 😆

@legalsylvain legalsylvain force-pushed the 16.0-IMP-apriori-pos_cashback_warning-into-pos_cashback branch from ad981bb to 1dfebef Compare February 24, 2025 11:09
@legalsylvain legalsylvain force-pushed the 16.0-IMP-apriori-pos_cashback_warning-into-pos_cashback branch from 1dfebef to 19a4cc5 Compare February 24, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants