Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_banking_sepa_direct_debit: Migration to 16.0 #1029

Merged

Conversation

Reyes4711-S73
Copy link
Contributor

@Reyes4711-S73 Reyes4711-S73 commented Feb 7, 2023

superseed from #1019
Standard migration to 16.0

@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_sepa_direct_debit branch 5 times, most recently from 7081349 to ed69c75 Compare February 8, 2023 09:25
@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_sepa_direct_debit branch from ed69c75 to 9f254d0 Compare March 1, 2023 11:09
@pedrobaeza
Copy link
Member

This should include the part of #1031 that corresponds to this.

@Reyes4711-S73
Copy link
Contributor Author

@pedrobaeza Added #1031

@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_sepa_direct_debit branch from 7ea7936 to d731b49 Compare March 13, 2023 14:19
@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_sepa_direct_debit branch 7 times, most recently from 10f1fdc to f39016b Compare March 21, 2023 12:31
@AntoniRomera
Copy link

Any progress?

@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_sepa_direct_debit branch 3 times, most recently from 0827939 to f5d6835 Compare April 5, 2023 11:02
@AntoniRomera
Copy link

Functional Review

It seems correct, I have created a debit order and I have tried to generate the file, it seems to have the XML schema, the only thing missing would be a warning that the journal does not have a bank account configured or let you set the bank account by hand if it does not.

@fgarcia-humanoide fgarcia-humanoide mentioned this pull request Apr 28, 2023
14 tasks
@manuelcalerosolis
Copy link

@Reyes4711-S73

You may need to update the test-requirements.txt, this dependency has already been merged.

@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_sepa_direct_debit branch from f5d6835 to aea2102 Compare May 4, 2023 05:54
@Reyes4711-S73
Copy link
Contributor Author

@manuelcalerosolis done

oca-travis and others added 15 commits May 29, 2023 08:00
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-payment-14.0/bank-payment-14.0-account_banking_sepa_direct_debit
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_sepa_direct_debit/
Currently translated at 100.0% (77 of 77 strings)

Translation: bank-payment-14.0/bank-payment-14.0-account_banking_sepa_direct_debit
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_sepa_direct_debit/es_AR/
…uld not be required

The bank account is taken from the mandate. Mandate is autopopulated if not found.
sepa_credit_transfer: bank_account_required back to True
Partial revert of the breakage of PR OCA#875

account_banking_sepa_direct_debit 14.0.1.3.0
[UPD] Update account_banking_sepa_direct_debit.pot

[UPD] README.rst
…, account_banking_direct_debit: Remove Environment.manage()

Environment.manage() is deprecated in v 15.0
…nt refactoring

Notable changes:

- InstrId and EndToEndId tags are now filled with the journal entry ID,
  as there's no bank payment line identifier.
From this version, Odoo already includes code on the
account.payment.method creation for adding such method to each journal:

https://github.com/odoo/odoo/blob/a93ed75cb80f16f/addons/account/models/account_payment_method.py#L24-L38

so we don't need to explicitly create them for the new payment methods
we are adding in these modules.

TT41146
@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_sepa_direct_debit branch from 7392fb8 to ffff2df Compare May 29, 2023 06:10
@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-migration-account_banking_sepa_direct_debit branch from ffff2df to d886973 Compare May 29, 2023 06:12
@Reyes4711-S73
Copy link
Contributor Author

@pedrobaeza Done

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

Thanks

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1029-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 95b23bf into OCA:16.0 Jun 3, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3ed6953. Thanks a lot for contributing to OCA. ❤️

@Reyes4711-S73 Reyes4711-S73 deleted the 16.0-migration-account_banking_sepa_direct_debit branch June 5, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.