Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][ADD] account_payment_order_return #395

Merged
merged 4 commits into from
Oct 13, 2017

Conversation

luismontalba
Copy link
Member

Account Payment Order Return

This module adds a check in the wizard where move lines are imported into
payment order.
This check lets avoid selecting lines from invoices linked to a payment return.

Usage

  • Go to Invoicing > Payments > Debit Orders.
  • Create a new record.
  • Click on button "Create Payment Lines fron Journal Items" to open the
    wizard.
  • Click on the "Linked to an Invoice or Refund " check.
  • Click on the "Avoid move lines from returns " check.
  • Fill other options.
  • Click on button "Add All Move Lines".

cc @Tecnativa

@luismontalba luismontalba force-pushed the 9.0-add-account_payment_order_return branch from 3457fa9 to fcc910b Compare October 3, 2017 16:26
{
'name': 'Account Payment Order Return',
'version': '9.0.1.0.0',
'category': 'Project Management',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change category

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Category changed

@sergio-teruel
Copy link
Contributor

I con not try in runbot... i think now is very busy jeje... OCA Codesprint...
But code review ok

@luismontalba luismontalba force-pushed the 9.0-add-account_payment_order_return branch from 8b364d2 to db8febe Compare October 4, 2017 08:37
@luismontalba
Copy link
Member Author

Runbot OK again !

class AccountPaymentLineCreate(models.TransientModel):
_inherit = 'account.payment.line.create'

avoid_returned = fields.Boolean(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the contrary logic: put a field called include_returned and unless this is checked, you include in the domain the new condition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubells @chienandalu please review

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot 👍

@pedrobaeza pedrobaeza merged commit 4afd597 into OCA:9.0 Oct 13, 2017
@pedrobaeza pedrobaeza deleted the 9.0-add-account_payment_order_return branch October 13, 2017 11:22
@pedrobaeza
Copy link
Member

Please migrate it to v10/v11

cubells pushed a commit to Tecnativa/bank-payment that referenced this pull request Sep 21, 2018
sebalix pushed a commit to camptocamp/bank-payment that referenced this pull request Feb 25, 2019
sebalix pushed a commit to camptocamp/bank-payment that referenced this pull request Feb 25, 2019
kittiu pushed a commit to kittiu/bank-payment that referenced this pull request Mar 29, 2019
joao-p-marques pushed a commit to Tecnativa/bank-payment that referenced this pull request Feb 11, 2021
joao-p-marques pushed a commit to Tecnativa/bank-payment that referenced this pull request Feb 11, 2021
joao-p-marques pushed a commit to Tecnativa/bank-payment that referenced this pull request Feb 11, 2021
joao-p-marques pushed a commit to Tecnativa/bank-payment that referenced this pull request Mar 17, 2021
ThomasBinsfeld pushed a commit to acsone/bank-payment that referenced this pull request Mar 23, 2021
i-vyshnevska pushed a commit to camptocamp/bank-payment that referenced this pull request Apr 7, 2021
Signed-off-by pedrobaeza
bizzappdev pushed a commit to BizzAppDev-Systems/bank-payment that referenced this pull request Mar 6, 2023
aktiv-heli-kantawala pushed a commit to aktiv-heli-kantawala/bank-payment that referenced this pull request Jul 26, 2023
almumu pushed a commit to aurestic/bank-payment that referenced this pull request Sep 26, 2024
almumu pushed a commit to aurestic/bank-payment that referenced this pull request Jan 15, 2025
almumu added a commit to aurestic/bank-payment that referenced this pull request Jan 21, 2025
* [ADD] account_payment_order_return (OCA#395)

* [MIG] account_payment_order_return: Migration to 11.0

* [12.0][MIG] account_payment_order_return

:100644 100644 d46b1318 a23b471a M	account_payment_order_return/README.rst
:100644 100644 340d1c77 1235bcb1 M	account_payment_order_return/__manifest__.py
:100644 100644 a341cc9d be7d7bbb M	account_payment_order_return/i18n/account_payment_order_return.pot
:100644 100644 60be6ab8 e6b32b37 M	account_payment_order_return/readme/CONTRIBUTORS.rst
:100644 100644 a8591d03 826c26df M	account_payment_order_return/readme/USAGE.rst
:100644 100644 450f2d9e a5f5d975 M	account_payment_order_return/static/description/index.html

* fix domain in payment_order_return

fix domain in payment_order_return in order to avoid problems with moves without associated invoice as discused at OCA#718

* [IMP] account_payment_order_return: black, isort, prettier

* [MIG] account_payment_order_return: Migration to 13.0

TT27858

* [FIX] account_payment_order_return: Set correct journal in tests to prevent error

* [FIX] account_payment_order_return: Fix tests

* [MIG] account_payment_order_return: Migration to 14.0

TT28728

* [FIX] account_payment_order_return: Fix tests

Don't post the invoice if it is already posted.
See odoo/odoo@80c2818

* account_payment_order_return 14.0.1.0.1

* [FIX] account_payment_order_return: Don't fail due to tz

When the test hour is around midnight, and demo data using CET/CEST
timezones, current code fails due to some asserts not having this into
consideration. This fix avoids such problem, and irons the execution
no matter the hour.

* [MIG][15.0]account_payment_order_return:Migration to 15.0

* [IMP] account_payment_order_return: test performance improvement
- Include context keys for avoiding mail operations overhead.

* [BOT] post-merge updates

* [MIG] account_payment_order_return: Migration to 16.0

* [BOT] post-merge updates

* Added translation using Weblate (Italian)

* Translated using Weblate (Italian)

Currently translated at 100.0% (2 of 2 strings)

Translation: bank-payment-16.0/bank-payment-16.0-account_payment_order_return
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_payment_order_return/it/

* [IMP] account_payment_order_return: pre-commit auto fixes

* [MIG] account_payment_order_return: Migration to 17.0

---------

Co-authored-by: Luis M. Ontalba <[email protected]>
Co-authored-by: cubells <[email protected]>
Co-authored-by: Kitti U <[email protected]>
Co-authored-by: Javier Colmeiro <[email protected]>
Co-authored-by: João Marques <[email protected]>
Co-authored-by: Víctor Martínez <[email protected]>
Co-authored-by: OCA-git-bot <[email protected]>
Co-authored-by: Pedro M. Baeza <[email protected]>
Co-authored-by: Ruchir Shukla <[email protected]>
Co-authored-by: josep-tecnativa <[email protected]>
Co-authored-by: mymage <[email protected]>
anmarmo1 pushed a commit to aurestic/bank-payment that referenced this pull request Jan 31, 2025
* [ADD] account_payment_order_return (OCA#395)

* [MIG] account_payment_order_return: Migration to 11.0

* [12.0][MIG] account_payment_order_return

:100644 100644 d46b1318 a23b471a M	account_payment_order_return/README.rst
:100644 100644 340d1c77 1235bcb1 M	account_payment_order_return/__manifest__.py
:100644 100644 a341cc9d be7d7bbb M	account_payment_order_return/i18n/account_payment_order_return.pot
:100644 100644 60be6ab8 e6b32b37 M	account_payment_order_return/readme/CONTRIBUTORS.rst
:100644 100644 a8591d03 826c26df M	account_payment_order_return/readme/USAGE.rst
:100644 100644 450f2d9e a5f5d975 M	account_payment_order_return/static/description/index.html

* fix domain in payment_order_return

fix domain in payment_order_return in order to avoid problems with moves without associated invoice as discused at OCA#718

* [IMP] account_payment_order_return: black, isort, prettier

* [MIG] account_payment_order_return: Migration to 13.0

TT27858

* [FIX] account_payment_order_return: Set correct journal in tests to prevent error

* [FIX] account_payment_order_return: Fix tests

* [MIG] account_payment_order_return: Migration to 14.0

TT28728

* [FIX] account_payment_order_return: Fix tests

Don't post the invoice if it is already posted.
See odoo/odoo@80c2818

* account_payment_order_return 14.0.1.0.1

* [FIX] account_payment_order_return: Don't fail due to tz

When the test hour is around midnight, and demo data using CET/CEST
timezones, current code fails due to some asserts not having this into
consideration. This fix avoids such problem, and irons the execution
no matter the hour.

* [MIG][15.0]account_payment_order_return:Migration to 15.0

* [IMP] account_payment_order_return: test performance improvement
- Include context keys for avoiding mail operations overhead.

* [BOT] post-merge updates

* [MIG] account_payment_order_return: Migration to 16.0

* [BOT] post-merge updates

* Added translation using Weblate (Italian)

* Translated using Weblate (Italian)

Currently translated at 100.0% (2 of 2 strings)

Translation: bank-payment-16.0/bank-payment-16.0-account_payment_order_return
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_payment_order_return/it/

* [IMP] account_payment_order_return: pre-commit auto fixes

* [MIG] account_payment_order_return: Migration to 17.0

---------

Co-authored-by: Luis M. Ontalba <[email protected]>
Co-authored-by: cubells <[email protected]>
Co-authored-by: Kitti U <[email protected]>
Co-authored-by: Javier Colmeiro <[email protected]>
Co-authored-by: João Marques <[email protected]>
Co-authored-by: Víctor Martínez <[email protected]>
Co-authored-by: OCA-git-bot <[email protected]>
Co-authored-by: Pedro M. Baeza <[email protected]>
Co-authored-by: Ruchir Shukla <[email protected]>
Co-authored-by: josep-tecnativa <[email protected]>
Co-authored-by: mymage <[email protected]>
anmarmo1 pushed a commit to aurestic/bank-payment that referenced this pull request Feb 2, 2025
* [ADD] account_payment_order_return (OCA#395)

* [MIG] account_payment_order_return: Migration to 11.0

* [12.0][MIG] account_payment_order_return

:100644 100644 d46b1318 a23b471a M	account_payment_order_return/README.rst
:100644 100644 340d1c77 1235bcb1 M	account_payment_order_return/__manifest__.py
:100644 100644 a341cc9d be7d7bbb M	account_payment_order_return/i18n/account_payment_order_return.pot
:100644 100644 60be6ab8 e6b32b37 M	account_payment_order_return/readme/CONTRIBUTORS.rst
:100644 100644 a8591d03 826c26df M	account_payment_order_return/readme/USAGE.rst
:100644 100644 450f2d9e a5f5d975 M	account_payment_order_return/static/description/index.html

* fix domain in payment_order_return

fix domain in payment_order_return in order to avoid problems with moves without associated invoice as discused at OCA#718

* [IMP] account_payment_order_return: black, isort, prettier

* [MIG] account_payment_order_return: Migration to 13.0

TT27858

* [FIX] account_payment_order_return: Set correct journal in tests to prevent error

* [FIX] account_payment_order_return: Fix tests

* [MIG] account_payment_order_return: Migration to 14.0

TT28728

* [FIX] account_payment_order_return: Fix tests

Don't post the invoice if it is already posted.
See odoo/odoo@80c2818

* account_payment_order_return 14.0.1.0.1

* [FIX] account_payment_order_return: Don't fail due to tz

When the test hour is around midnight, and demo data using CET/CEST
timezones, current code fails due to some asserts not having this into
consideration. This fix avoids such problem, and irons the execution
no matter the hour.

* [MIG][15.0]account_payment_order_return:Migration to 15.0

* [IMP] account_payment_order_return: test performance improvement
- Include context keys for avoiding mail operations overhead.

* [BOT] post-merge updates

* [MIG] account_payment_order_return: Migration to 16.0

* [BOT] post-merge updates

* Added translation using Weblate (Italian)

* Translated using Weblate (Italian)

Currently translated at 100.0% (2 of 2 strings)

Translation: bank-payment-16.0/bank-payment-16.0-account_payment_order_return
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_payment_order_return/it/

* [IMP] account_payment_order_return: pre-commit auto fixes

* [MIG] account_payment_order_return: Migration to 17.0

---------

Co-authored-by: Luis M. Ontalba <[email protected]>
Co-authored-by: cubells <[email protected]>
Co-authored-by: Kitti U <[email protected]>
Co-authored-by: Javier Colmeiro <[email protected]>
Co-authored-by: João Marques <[email protected]>
Co-authored-by: Víctor Martínez <[email protected]>
Co-authored-by: OCA-git-bot <[email protected]>
Co-authored-by: Pedro M. Baeza <[email protected]>
Co-authored-by: Ruchir Shukla <[email protected]>
Co-authored-by: josep-tecnativa <[email protected]>
Co-authored-by: mymage <[email protected]>
anmarmo1 pushed a commit to aurestic/bank-payment that referenced this pull request Feb 18, 2025
* [ADD] account_payment_order_return (OCA#395)

* [MIG] account_payment_order_return: Migration to 11.0

* [12.0][MIG] account_payment_order_return

:100644 100644 d46b1318 a23b471a M	account_payment_order_return/README.rst
:100644 100644 340d1c77 1235bcb1 M	account_payment_order_return/__manifest__.py
:100644 100644 a341cc9d be7d7bbb M	account_payment_order_return/i18n/account_payment_order_return.pot
:100644 100644 60be6ab8 e6b32b37 M	account_payment_order_return/readme/CONTRIBUTORS.rst
:100644 100644 a8591d03 826c26df M	account_payment_order_return/readme/USAGE.rst
:100644 100644 450f2d9e a5f5d975 M	account_payment_order_return/static/description/index.html

* fix domain in payment_order_return

fix domain in payment_order_return in order to avoid problems with moves without associated invoice as discused at OCA#718

* [IMP] account_payment_order_return: black, isort, prettier

* [MIG] account_payment_order_return: Migration to 13.0

TT27858

* [FIX] account_payment_order_return: Set correct journal in tests to prevent error

* [FIX] account_payment_order_return: Fix tests

* [MIG] account_payment_order_return: Migration to 14.0

TT28728

* [FIX] account_payment_order_return: Fix tests

Don't post the invoice if it is already posted.
See odoo/odoo@80c2818

* account_payment_order_return 14.0.1.0.1

* [FIX] account_payment_order_return: Don't fail due to tz

When the test hour is around midnight, and demo data using CET/CEST
timezones, current code fails due to some asserts not having this into
consideration. This fix avoids such problem, and irons the execution
no matter the hour.

* [MIG][15.0]account_payment_order_return:Migration to 15.0

* [IMP] account_payment_order_return: test performance improvement
- Include context keys for avoiding mail operations overhead.

* [BOT] post-merge updates

* [MIG] account_payment_order_return: Migration to 16.0

* [BOT] post-merge updates

* Added translation using Weblate (Italian)

* Translated using Weblate (Italian)

Currently translated at 100.0% (2 of 2 strings)

Translation: bank-payment-16.0/bank-payment-16.0-account_payment_order_return
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_payment_order_return/it/

* [IMP] account_payment_order_return: pre-commit auto fixes

* [MIG] account_payment_order_return: Migration to 17.0

---------

Co-authored-by: Luis M. Ontalba <[email protected]>
Co-authored-by: cubells <[email protected]>
Co-authored-by: Kitti U <[email protected]>
Co-authored-by: Javier Colmeiro <[email protected]>
Co-authored-by: João Marques <[email protected]>
Co-authored-by: Víctor Martínez <[email protected]>
Co-authored-by: OCA-git-bot <[email protected]>
Co-authored-by: Pedro M. Baeza <[email protected]>
Co-authored-by: Ruchir Shukla <[email protected]>
Co-authored-by: josep-tecnativa <[email protected]>
Co-authored-by: mymage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants