Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look for issues in all states for commenting #216

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Look for issues in all states for commenting #216

merged 1 commit into from
Nov 6, 2023

Conversation

alexey-pelykh
Copy link
Contributor

No description provided.

@alexey-pelykh
Copy link
Contributor Author

@pedrobaeza @sbidoul a tiny adjustment, see https://github.com/sigmavirus24/github3.py/blob/6e9f03d771043a480ac6571849ffc8f2abca1888/src/github3/repos/repo.py#L1107

@alexey-pelykh alexey-pelykh force-pushed the look-for-closed-issues-also branch from a3d31f8 to a3402b4 Compare October 10, 2022 12:04
legalsylvain
legalsylvain approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes senses.

SirAionTech
SirAionTech approved these changes Nov 6, 2023
View reviewed changes
Copy link

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Only code review, looks good to me

@legalsylvain
Copy link
Collaborator

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch master-ocabot-merge-pr-216-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5687d24. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 5687d24 into OCA:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@SirAionTech SirAionTech SirAionTech approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexey-pelykh @legalsylvain @OCA-git-bot @pedrobaeza @SirAionTech