[15.0][MIG] product_variant_default_code: Migration to version 15.0 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der_default_code Separate the default code assignment in 2 steps, one obtains the code and the other set this value on product. Now is easier to extend this method.
* IMP dependency, field name, complete view * FIX move sale.settings to base settings * IMP reference mask use untranslate attribute names * FIX some tests with @chienandalu remarks
* [IMP] Improve French (fr) translation * [FIX] Fixed bad display of config. settings * [FIX] Display product attribute value code when open the product attribute form view from product form view
As needed in v11
Currently translated at 63.6% (14 of 22 strings) Translation: product-variant-12.0/product-variant-12.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_default_code/hr/
…ept multiple recordset
Currently translated at 100.0% (22 of 22 strings) Translation: product-variant-12.0/product-variant-12.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_default_code/pt/
missing the possibility to edit of attribute code in form view (and also tree view)
It was present in tree view, but not in form view, and now the tree is not editable.
When a variant is created, the mask is evaluated expecting the main language term, so we should avoid taking the translated value when we are in another language.
When an attribute code is already set, we don't wan't to change it by chance if we set a new name in the value. The onchange should be just a helper to fill the initial value but it should be manually changed if needed later on.
Tests can conflict with constriants added by other modules for the default_code We should create different product templates only if we can be sure they will compute different default_codes, otherwise they might trigger the unique(default_code) constrainted, if introduced by another module. TT28423
Currently translated at 74.0% (20 of 27 strings) Translation: product-variant-14.0/product-variant-14.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-14-0/product-variant-14-0-product_variant_default_code/it/
Currently translated at 77.7% (21 of 27 strings) Translation: product-variant-14.0/product-variant-14.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-14-0/product-variant-14-0-product_variant_default_code/it/
Currently translated at 100.0% (27 of 27 strings) Translation: product-variant-14.0/product-variant-14.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-14-0/product-variant-14-0-product_variant_default_code/it/
…or missing product template attribute values.
|
/ocabot migration product_variant_default_code |
|
Check pre-commit |
pilarvargas-tecnativa
force-pushed
the
15.0-mig-product_variant_default_code
branch
from
f28b380 to
7bcb1eb
Compare
chienandalu
reviewed
May 4, 2023
pilarvargas-tecnativa
force-pushed
the
15.0-mig-product_variant_default_code
branch
from
7bcb1eb to
e5384df
Compare
pedrobaeza
reviewed
May 5, 2023
pilarvargas-tecnativa
force-pushed
the
15.0-mig-product_variant_default_code
branch
from
e5384df to
e9a193f
Compare
This was referenced May 5, 2023
pedrobaeza
approved these changes
May 6, 2023
stefan-tecnativa
approved these changes
May 8, 2023
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 255c5fc. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT36978
@stefan-tecnativa @chienandalu please review