ISSUES-557: Editing a bookmark prompts "Duplicate bookmark" on Save #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i believe editbookmarkviewcontroller is also used when creating a new bookmark, so we'd still need to check for dupes (#480). this pr would reverse d889a08, which originally fixed #480. any insights or feedback, @aaronbrethorst? |
|
Ah I see! That makes sense! |
|
Hey @cathy810218 - good to see you on here! Check to see if |
|
Hi @aaronbrethorst haha! yes it's been awhile and I am trying to re-learn ios development. |
Issue: OneBusAway#557 Description: If user is adding a new bookmark, check if there is a duplicate; otherwise, on Save when editing a bookmark, we will not prompt a duplicate alert
cathy810218
force-pushed
the
ISSUES-557
branch
from
86d7fa5 to
6619f6a
Compare
video-1636768733.mp4 |
|
thanks, @cathy810218! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#557
Description:
Remove the duplicated bookmark check so it does not prompt the alert asking if the intention is to duplicate bookmark. If the user did not change anything in the bookmark, on Save, it should just save the unedited bookmark.
alan note for computer: fixes #557