Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve map sheet UX for VoiceOver users #576

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

ualch9
Copy link
Member

@ualch9 ualch9 commented Nov 30, 2021

Oops, didn't mean to merge #575 yet, shouldve marked it as a draft.

Beta feedback on #575, summarized:
When the sheet is fully expanded, the prompt is confusing for Voiceover users, since the map is now inaccessible for Voiceover (see screenshot). Additionally, the map should not be disabled for all voiceover users, since low-vision users are still able to interact with the map visually.

Stuff to do:

  • When the sheet is fully expanded, disable mapview interactions. When the sheet is partially collapsed, enable mapview.
  • When the user centers the map on their location, partially collapse the sheet to enable mapview interaction.
  • [ ] Add a button to recent stops list to "expand" the search radius if no stops were loaded (via perferredLoadDataRegionFudgeFactor from commit ae73f03) removed from this PR, see Add a button to recent stops list to "expand" the search radius if no stops were loaded #578

image

@ualch9 ualch9 changed the title Continue working on default to full sheet on voiceover Improve map sheet UX for VoiceOver users Nov 30, 2021
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aaronbrethorst aaronbrethorst merged commit 3d581c6 into OneBusAway:master Dec 8, 2021
@ualch9 ualch9 deleted the recent_stops branch December 10, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants