-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][Client] Add support for enum-typed discriminator #10959
base: master
Are you sure you want to change the base?
[Java][Client] Add support for enum-typed discriminator #10959
Conversation
539d8f8
to
02e8e35
Compare
CircleCI reports that my PR have failed the command |
374f71d
to
8f26e8d
Compare
It seems that the problem was caused by the method |
@wing328 Could you please take a look at my PR? Thank you! |
8f26e8d
to
a43330d
Compare
Given that the CI is passing completely, and this is resolving a pesky bug with enums, would you mind taking a look @wing328 ? :) |
Any update on this? |
Any updates? :) |
Hello, |
Fixes #806
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
Java committee members: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch Please take your time to check my PR. Thank you.