Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Client] Add support for enum-typed discriminator #10959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnlinp
Copy link

Fixes #806

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Java committee members: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch Please take your time to check my PR. Thank you.

@johnlinp johnlinp force-pushed the fix-discriminator-enum-property-name branch from 539d8f8 to 02e8e35 Compare November 25, 2021 04:11
@johnlinp johnlinp changed the title Add support for enum-typed discriminator [Java][Client] Add support for enum-typed discriminator Nov 25, 2021
@johnlinp
Copy link
Author

johnlinp commented Nov 25, 2021

CircleCI reports that my PR have failed the command mvn --no-snapshot-updates --quiet clean install -Dorg.slf4j.simpleLogger.defaultLogLevel=error. However, I can successfully execute this command on my local machine. Can someone give me some hints about how to fix it? Thank you.

@johnlinp johnlinp force-pushed the fix-discriminator-enum-property-name branch 2 times, most recently from 374f71d to 8f26e8d Compare November 27, 2021 03:21
@johnlinp
Copy link
Author

johnlinp commented Nov 27, 2021

It seems that the problem was caused by the method public boolean isEnumProperty(). When I changed it into public boolean getIsEnumProperty(), the command will successfully execute on CircleCI.

@johnlinp
Copy link
Author

@wing328 Could you please take a look at my PR? Thank you!

@johnlinp johnlinp force-pushed the fix-discriminator-enum-property-name branch from 8f26e8d to a43330d Compare February 5, 2022 07:03
@aeneasr
Copy link
Contributor

aeneasr commented May 13, 2022

Given that the CI is passing completely, and this is resolving a pesky bug with enums, would you mind taking a look @wing328 ? :)

@CSALS
Copy link

CSALS commented Oct 14, 2023

Any update on this?

@elagerho
Copy link

Any updates? :)

@StrangePingouin
Copy link

Hello,
Any updates on this issue ?
I'm facing the exact same one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] Compilation failure when 'discriminator' is introduced
5 participants