-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Helidon MP release in generated project from 1.x to 2.x #11076
Conversation
BTW I have marked this as a draft because we are about to issue a new release, and this PR references that new release. I need to make sure the PR is not merged before our release but otherwise it is ready for review. |
I was thinking there should be microprofile generator that uses |
Not sure I understand. The existing Helidon 1.x support in the generator works exactly that way. It layers on the Users would do the same after this change but would get projects based on Helidon 2.x instead of 1.x. |
A new generator that is java-microprofile, rather java-helidon, and the generator has options for helidon, quarkus, etc. |
Got it. Now I understand what you meant. And I misspoke. The Helidon 1.x support--like several others (Quarkus, OpenLiberty, Thorntail)--layers on |
@@ -168,7 +168,7 @@ export class DefaultService { | |||
} | |||
|
|||
return this.httpClient.put<any>(`${this.configuration.basePath}/`, | |||
body, | |||
UNKNOWN_PARAM_NAME, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjquinno Is your change based on the latest master?
Can you pleas regenerate the samples by running ./bin/utils/ensure-up-to-date
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wing328 It was when I started it, and again when I rebased a week ago. But it seems in the time since my branch has fallen behind so I will rebase it and rerun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wing328 Just pushed to update a generated file. Please re-approve the workflow when you can.
docs/generators/java-helidon.md
Outdated
@@ -0,0 +1,304 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file added manually?
Files under docs/generators are supposed to be auto-generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is auto-generated. I added the generated file to git manually, as with new or updated generated samples file. I guess that's incorrect? I'll remove it from the PR then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wing328 Can you or someone please trigger the workflow again after my latest push? Thanks.
Tested locally and the result is good
|
Resolves #11043
beans.xml
in the generated project.docs/generator/java-helidon.md
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
Attention: @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)