Make moduleObject.mustache confirms to JSONEncodable. #11202

0x0c · 2021-12-30T13:57:38Z

This PR resolves #8925. Classes that is generated from moduleObject.mustache now confirms JSONEncodable to send user-defined model as multipart/form-data. Please let me know if any issue to merge this PR. Thank you :)

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (5.3.0), 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
- This PR contains some fixes for swift5 generator. @jgavris @ehyche @Edubits @jaz-ah @4brunu

4brunu · 2022-01-04T15:00:56Z

modules/openapi-generator/src/main/resources/swift5/Extensions.mustache

+
+extension JSONEncodable where Self: Encodable {
+    func encodeToJSON() -> Any {
+        let encoder = JSONEncoder()


@0x0c here instead of creating a new JSONEncoder, please use CodableHelper.jsonEncoder

Done with 1c06b4d

4brunu · 2022-01-04T15:03:55Z

modules/openapi-generator/src/main/resources/swift5/Extensions.mustache

+        guard let data = try? encoder.encode(self) else {
+            fatalError("Could not encode to json: \(self)")
+        }
+        return data.base64EncodedString(options: Data.Base64EncodingOptions())


@0x0c I'm a little worried about this.
When do we want to encode json as base64?
Only in multipart/form-data requests?
Can't we just return the json in Data?

@4brunu According to generated code, Data can encode to json as follows.

extension Data: JSONEncodable { func encodeToJSON() -> Any { return self.base64EncodedString(options: Data.Base64EncodingOptions()) } }

This code is implemented here. Therefore, I followed this code and encode json as base 64.

I see.
Could you please reuse that extension please?
return data.encodeToJSON()

I updated line 216 so please check 7836e27

4brunu · 2022-01-04T15:07:43Z

Hey @0x0c,
thanks for opening this PR,
I left some comments in your PR with some questions.
Thanks

4brunu · 2022-01-04T15:11:43Z

modules/openapi-generator/src/main/resources/swift5/modelObject.mustache

@@ -1,5 +1,5 @@
-{{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{{classname}}}: {{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable{{/useVapor}}{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}} {
-{{/objcCompatible}}{{#objcCompatible}}@objc {{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} class {{classname}}: NSObject, Codable {
+{{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{{classname}}}: {{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable{{/useVapor}}{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}}, JSONEncodable {


@0x0c to make the CI pass, could you please update this line to be

{{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{{classname}}}: {{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable, JSONEncodable{{/useVapor}}{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}}{

Because when using Vapor, we can't make the model conform to JSONEncodable

Done with aae8e6d

0x0c · 2022-01-04T16:31:16Z

@4brunu Thank you for your review. I updated codes. Please check it again. Thanks.

4brunu · 2022-01-04T16:34:24Z

@0x0c thanks for making the changes, let's wait for CI to see if passes.

4brunu · 2022-01-04T16:56:23Z

modules/openapi-generator/src/main/resources/swift5/Extensions.mustache

@@ -206,3 +206,13 @@ extension Set: RequestDecodable where Element: Content {
 extension Set: Content where Element: Content { }

 extension AnyCodable: Content {}{{/useVapor}}
+
+extension JSONEncodable where Self: Encodable {


@0x0c could you please move this entire block of code to line 63, so that it's not generated when using vapor, for CI to pass?

Done with ebd7d01

4brunu · 2022-01-04T16:59:23Z

modules/openapi-generator/src/main/resources/swift5/modelObject.mustache

-{{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{{classname}}}: {{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable{{/useVapor}}{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}} {
-{{/objcCompatible}}{{#objcCompatible}}@objc {{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} class {{classname}}: NSObject, Codable {
+{{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{{classname}}}: {{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable, JSONEncodable{{/useVapor}}{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}}{
+{{/objcCompatible}}{{#objcCompatible}}@objc {{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} class {{classname}}: NSObject, Codable, JSONEncodable {
 {{/objcCompatible}}



Could you please also add the JSONEncodable conformance after Codable in the following files, please?
modelEnum.mustache
modelInlineEnumDeclaration.mustache
modelOneOf.mustache

Done with d855a09 and 4929d5b .

…elOneOf

…ssue-8925

0x0c · 2022-01-04T17:18:27Z

@4brunu I fixed issues which you mentioned. Let's wait the result of CI again.

4brunu · 2022-01-04T17:29:18Z

modules/openapi-generator/src/main/resources/swift5/Extensions.mustache

+}
+{{/useVapor}}{{#generateModelAdditionalProperties}}


@0x0c just a small nit, could you please make this in one line to improve the generated code?

}{{/useVapor}}{{#generateModelAdditionalProperties}}

Done with 8b1529f

Thanks, could you please update the sample projects also?

The last commit brought a lot of undesired changes, could you please revert it?
Maybe you need to first merge the master branch into yours and then run the following commands.

./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh

Done with 5a1661b and 51fe33f

Could you please explain why some enums are not JSONEncodable?
Is there any issue that you found?

Since enum value that confirms RawRepresentable a.k.a primitive value is already confirm JSONEncodable here and here, it seems to that modelEnum.mustache and modelInlineEnumDeclaration.mustache should not confirm JSONCodable. If confirm explicitly, Xcode could not build generated source code.

You are right, thanks 👍

This reverts commit 6ec206b.

4brunu · 2022-01-06T11:46:15Z

modules/openapi-generator/src/main/resources/swift5/modelEnum.mustache

@@ -1,4 +1,4 @@
-{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} enum {{classname}}: {{dataType}}, {{#useVapor}}Content, Hashable{{/useVapor}}{{^useVapor}}Codable{{/useVapor}}, CaseIterable{{#enumUnknownDefaultCase}}{{#isInteger}}, CaseIterableDefaultsLast{{/isInteger}}{{#isFloat}}, CaseIterableDefaultsLast{{/isFloat}}{{#isDouble}}, CaseIterableDefaultsLast{{/isDouble}}{{#isString}}, CaseIterableDefaultsLast{{/isString}}{{/enumUnknownDefaultCase}} {
+{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} enum {{classname}}: {{dataType}}, {{#useVapor}}Content, Hashable{{/useVapor}}{{^useVapor}}Codable{{#isContainer}}{{#isString}}{{^isInteger}}{{^isFloat}}{{^isDouble}}, JSONEncodable{{/isDouble}}{{/isFloat}}{{/isInteger}}{{/isString}}{{/isContainer}}{{/useVapor}}, CaseIterable{{#enumUnknownDefaultCase}}{{#isInteger}}, CaseIterableDefaultsLast{{/isInteger}}{{#isFloat}}, CaseIterableDefaultsLast{{/isFloat}}{{#isDouble}}, CaseIterableDefaultsLast{{/isDouble}}{{#isString}}, CaseIterableDefaultsLast{{/isString}}{{/enumUnknownDefaultCase}} {


@0x0c Could you please explain this logic please?

{{#isContainer}}{{#isString}}{{^isInteger}}{{^isFloat}}{{^isDouble}}, JSONEncodable{{/isDouble}}{{/isFloat}}{{/isInteger}}{{/isString}}{{/isContainer}}

Same reason of #11202 (comment).

So an Enum should conform to JSONEncodable if it's a string os is a container? Or if it's a string and is a container?

Sorry I copied and pasted modelInlineEnumDeclaration.mustache and it is not appropriate. modelInlineEnumDeclaration.mustache confirms String when it is a container. I fixed with 235b824

4brunu · 2022-01-06T12:34:00Z

modules/openapi-generator/src/main/resources/swift5/modelObject.mustache

@@ -1,5 +1,5 @@
-{{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{{classname}}}: {{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable{{/useVapor}}{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}} {
-{{/objcCompatible}}{{#objcCompatible}}@objc {{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} class {{classname}}: NSObject, Codable {
+{{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{{classname}}}: {{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable, JSONEncodable{{/useVapor}}{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}}{


@0x0c another nit that I found is that at the end of the line, there is a space before the final { that was acidently removed and is creating some noise for example in the vapor client that shouldn't have any changes with this PR.
Could you please restore that space, to avoid noise in the generated code?
This command should generate the Swift sample projects.

./bin/generate-samples.sh bin/configs/swift5-* ` ``

Done with 672df35 and 8962b8b

4brunu · 2022-01-07T12:39:11Z

modules/openapi-generator/src/main/resources/swift5/modelInlineEnumDeclaration.mustache

@@ -1,4 +1,4 @@
-    {{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} enum {{enumName}}: {{^isContainer}}{{dataType}}{{/isContainer}}{{#isContainer}}String{{/isContainer}}, {{#useVapor}}Content, Hashable{{/useVapor}}{{^useVapor}}Codable{{/useVapor}}, CaseIterable{{#enumUnknownDefaultCase}}{{#isInteger}}, CaseIterableDefaultsLast{{/isInteger}}{{#isFloat}}, CaseIterableDefaultsLast{{/isFloat}}{{#isDouble}}, CaseIterableDefaultsLast{{/isDouble}}{{#isString}}, CaseIterableDefaultsLast{{/isString}}{{#isContainer}}, CaseIterableDefaultsLast{{/isContainer}}{{/enumUnknownDefaultCase}} {
+    {{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} enum {{enumName}}: {{^isContainer}}{{dataType}}{{/isContainer}}{{#isContainer}}String{{/isContainer}}, {{#useVapor}}Content, Hashable{{/useVapor}}{{^useVapor}}Codable{{^isContainer}}{{^isString}}{{^isInteger}}{{^isFloat}}{{^isDouble}}, JSONEncodable{{/isDouble}}{{/isFloat}}{{/isInteger}}{{/isString}}{{/isContainer}}{{/useVapor}}, CaseIterable{{#enumUnknownDefaultCase}}{{#isInteger}}, CaseIterableDefaultsLast{{/isInteger}}{{#isFloat}}, CaseIterableDefaultsLast{{/isFloat}}{{#isDouble}}, CaseIterableDefaultsLast{{/isDouble}}{{#isString}}, CaseIterableDefaultsLast{{/isString}}{{#isContainer}}, CaseIterableDefaultsLast{{/isContainer}}{{/enumUnknownDefaultCase}} {


@0x0c is it necessary to check is it's not container?
This implementation is different from modelEnum.mustache, is it normal?

Maybe it's related to #11202 (comment)?
If it's correct being different and you could give a bit of more context, I would appreciate it.

If modelEnumDeclaration.mustache is container, the enum confirms String. Therefore, we have to check whether the enum is container or not.

And this doesn't apply also to modelInlineEnumDeclaration.mustache?

Oh, sorry I missed type. In previous my post "If modelEnumDeclaration.mustache is container ..." is not correct.. "If modelInlineEnumDeclaration.mustache is container ..." is correct.

This PR looks good to me.
If you could explain why we need to check for container in one but not the other I would appreciate it, because this was something that was always a bit confusing to me

If you could explain why we need to check for container in one but not the other I would appreciate it, because this was something that was always a bit confusing to me

Sorry, I can't answer your question because a code for checking container is already implemented before I modify modelEnumDeclaration.mustache. I respect original mustache and don't change the mustache is better I think.

Originally, according to the first commit of these files, there is difference between modelEnum.mustache and modelInlineEnumDeclaration.mustache. One is checking for container and other is not.
See here and here.

I see, thanks for the explanation 👍

4brunu

Looks good to me 👍

0x0c · 2022-01-09T13:35:20Z

Thank you! Can't wait for merging this PR :)

4brunu · 2022-01-09T14:06:16Z

Thank you for the patient, making the requested changes and answering my questions 👍

honkmaster · 2022-02-07T15:21:00Z

@4brunu @0x0c Hello, I think I found an issue with this PR.

Within request, one may append query items, such as:

var localVariableUrlComponents = URLComponents(string: localVariableURLString)
localVariableUrlComponents?.queryItems = APIHelper.mapValuesToQueryItems([
 "_variable": variable?.encodeToJSON(),
])

If the variable is a string, the new encodeToJSON behaviour will break existing code. Previously, the variable was set as is. Now, the String is encoded as JSON... Is this really intended?

4brunu · 2022-02-07T15:39:11Z

That's weird.

openapi-generator/samples/client/petstore/swift5/resultLibrary/PetstoreClient/Classes/OpenAPIs/Models.swift

Lines 13 to 15 in 949b4e2

    
           extension JSONEncodable { 
        
               func encodeToJSON() -> Any { self } 
        
           }

openapi-generator/samples/client/petstore/swift5/resultLibrary/PetstoreClient/Classes/OpenAPIs/Extensions.swift

Line 18 in 949b4e2

extension String: JSONEncodable {}

Looking at the code, it shouldn't be encoded to json.

honkmaster · 2022-02-07T16:10:36Z

But it does.... :/

If you look at the extension, both apply to a String (as it is Encodable).
I don't know how the compiler decides which extension to take.
From our point of view, we only upgraded from 5.3.1 to 5.4.0 and now all our tests fail.

extension JSONEncodable where Self: Encodable {
    func encodeToJSON() -> Any {
        let encoder = CodableHelper.jsonEncoder
        guard let data = try? encoder.encode(self) else {
            fatalError("Could not encode to json: \(self)")
        }
        return data.encodeToJSON()
    }
}

 extension JSONEncodable { 
     func encodeToJSON() -> Any { self } 
 }

4brunu · 2022-02-07T16:52:36Z

@0x0c @honkmaster do you have a solution other than revert this PR? Thanks

4brunu · 2022-02-07T16:59:18Z

I think the solution should be something along those lines.
4brunu@4647a79
Basically we want to push the Json encoding as far into the stack as possible.

But I'm getting the following error
protocol 'JSONEncodable' as a type cannot conform to 'Encodable'

4brunu@4647a79#r66188797

Any suggestions?

Or maybe restrict the extension extension JSONEncodable where Self: Encodable so that it does not apply to so many types?

4brunu · 2022-02-07T18:14:05Z

I think I found a solution.
@honkmaster can you please test if this PR fixes the issue?
#11541

rhys-rant · 2022-03-07T11:12:54Z

But it does.... :/

If you look at the extension, both apply to a String (as it is Encodable). I don't know how the compiler decides which extension to take. From our point of view, we only upgraded from 5.3.1 to 5.4.0 and now all our tests fail.
extension JSONEncodable where Self: Encodable {
    func encodeToJSON() -> Any {
        let encoder = CodableHelper.jsonEncoder
        guard let data = try? encoder.encode(self) else {
            fatalError("Could not encode to json: \(self)")
        }
        return data.encodeToJSON()
    }
}
extension JSONEncodable { 
    func encodeToJSON() -> Any { self } 
}

I have a similar problem on 5.4.0 FWIW.
I'm now finding (after much debugging!) that uploading an image from a local file URL is unfortunately encoding the URL as a String instead of keeping it as a URL. When the FormDataEncoding.encode method is then run, the String representing the URL is then itself converted, rather than the file being read from the file URL it points to. As a result, the server I'm uploading images to is failing, throwing a 500 error, as it (understandably) cannot decode an image from a device-local file URL.

4brunu · 2022-03-07T11:14:32Z

Could you please test if the version in master branch works for you?

rhys-rant · 2022-03-07T11:19:52Z

Could you please test if the version in master branch works for you?

Yep, will give it a try. Do you know of a quick way to get the master branch installed via Homebrew, or do I have to clone and build myself? 😄

4brunu · 2022-03-07T11:23:24Z

You have to clone it and build it yourself.
Clone it, run ./mvnw package to build it and the output jar will be located at modules/openapi-generator-cli/target/openapi-generator-cli.jar.
Then you should copy the jar somewhere you want and the openapi through the jar file.

java -jar openapi-generator-cli.jar generate ...

denizdogan · 2022-05-02T18:03:24Z

@4brunu For what it's worth, I have the exact same issue as @rhys-rantmedia in 5.4.0. I've tried debugging it, but I really can't figure out where in the whole process the URL gets turned into a local path string.

4brunu · 2022-05-03T10:07:11Z

For now the only solution is to build from source or to use an older version.

4brunu · 2022-05-03T10:08:31Z

@denizdogan could you please confirm if that works for you?

denizdogan · 2022-05-03T11:10:01Z

@4brunu Yeah, I just resorted to using 5.3.1 again, no issues :) Thanks.

4brunu · 2022-05-03T17:24:35Z

Sorry for the trouble, this will be fixed when the next version is out

0x0c added 2 commits December 30, 2021 22:48

Make moduleObject.mustache confirms to JSONEncodable.

09dacc7

Regenerate samples

fc433db

0x0c mentioned this pull request Dec 30, 2021

[REQ] [Swift5] Encode a user-defined model to Json when using multipart/form-data #8925

Closed

4brunu reviewed Jan 4, 2022

View reviewed changes

0x0c added 4 commits January 5, 2022 00:50

Don't confirm JSONEncodable when using Vapor.

aae8e6d

Use CodableHelper.jsonEncoder

1c06b4d

Encode Data using encodeToJSON()

7836e27

Update sample

e55c757

4brunu reviewed Jan 4, 2022

View reviewed changes

0x0c added 5 commits January 5, 2022 02:01

Don't extend JSONEncodable when using Vapor.

ebd7d01

Add JSONEncodable in moduleEnum, moduleInlineEnumDeclaration, and mod…

d855a09

…elOneOf

Merge branch 'master' into issue-8925

4929d5b

Update sample

f4da07a

Merge branch 'issue-8925' of github.com:0x0c/openapi-generator into i…

7c1a144

…ssue-8925

4brunu reviewed Jan 4, 2022

View reviewed changes

0x0c added 5 commits January 5, 2022 02:34

Remove line break.

8b1529f

Update sample

6ec206b

Revert "Update sample"

5a1661b

This reverts commit 6ec206b.

Don't confirm JSONEncodable when enum confirms RawRepresentable.

7acc1fb

Update sample

51fe33f

4brunu reviewed Jan 6, 2022

View reviewed changes

Add space before {

672df35

0x0c added 2 commits January 6, 2022 21:40

Update sample

8962b8b

Don't confirm JSONEncodable when enum confirms RawRepresentable.

235b824

4brunu reviewed Jan 7, 2022

View reviewed changes

4brunu approved these changes Jan 9, 2022

View reviewed changes

wing328 added Client: Swift Issue: Bug labels Jan 9, 2022

wing328 added this to the 5.4.0 milestone Jan 9, 2022

wing328 merged commit febf496 into OpenAPITools:master Jan 9, 2022

4brunu mentioned this pull request Feb 7, 2022

[Swift5][client] try to fix JsonEncondable #11541

Merged

5 tasks

rhys-rant mentioned this pull request Mar 7, 2022

[REQ] Distribute versions on Homebrew #11816

Open

		@@ -1,4 +1,4 @@
		{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} enum {{classname}}: {{dataType}}, {{#useVapor}}Content, Hashable{{/useVapor}}{{^useVapor}}Codable{{/useVapor}}, CaseIterable{{#enumUnknownDefaultCase}}{{#isInteger}}, CaseIterableDefaultsLast{{/isInteger}}{{#isFloat}}, CaseIterableDefaultsLast{{/isFloat}}{{#isDouble}}, CaseIterableDefaultsLast{{/isDouble}}{{#isString}}, CaseIterableDefaultsLast{{/isString}}{{/enumUnknownDefaultCase}} {
		{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} enum {{classname}}: {{dataType}}, {{#useVapor}}Content, Hashable{{/useVapor}}{{^useVapor}}Codable{{#isContainer}}{{#isString}}{{^isInteger}}{{^isFloat}}{{^isDouble}}, JSONEncodable{{/isDouble}}{{/isFloat}}{{/isInteger}}{{/isString}}{{/isContainer}}{{/useVapor}}, CaseIterable{{#enumUnknownDefaultCase}}{{#isInteger}}, CaseIterableDefaultsLast{{/isInteger}}{{#isFloat}}, CaseIterableDefaultsLast{{/isFloat}}{{#isDouble}}, CaseIterableDefaultsLast{{/isDouble}}{{#isString}}, CaseIterableDefaultsLast{{/isString}}{{/enumUnknownDefaultCase}} {

		}
		{{/useVapor}}{{#generateModelAdditionalProperties}}

Make moduleObject.mustache confirms to JSONEncodable. #11202

Make moduleObject.mustache confirms to JSONEncodable. #11202

Conversation

0x0c commented Dec 30, 2021 • edited Loading

PR checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

4brunu commented Jan 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0x0c commented Jan 4, 2022

4brunu commented Jan 4, 2022

4brunu Jan 4, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0x0c commented Jan 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0x0c Jan 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0x0c Jan 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

4brunu left a comment

Choose a reason for hiding this comment

0x0c commented Jan 9, 2022

4brunu commented Jan 9, 2022

honkmaster commented Feb 7, 2022

4brunu commented Feb 7, 2022

honkmaster commented Feb 7, 2022 • edited Loading

4brunu commented Feb 7, 2022

4brunu commented Feb 7, 2022 • edited Loading

4brunu commented Feb 7, 2022

rhys-rant commented Mar 7, 2022

4brunu commented Mar 7, 2022

rhys-rant commented Mar 7, 2022

4brunu commented Mar 7, 2022

denizdogan commented May 2, 2022

4brunu commented May 3, 2022

4brunu commented May 3, 2022

denizdogan commented May 3, 2022

4brunu commented May 3, 2022

0x0c commented Dec 30, 2021 •

edited

Loading

4brunu Jan 4, 2022 •

edited

Loading

0x0c Jan 6, 2022 •

edited

Loading

0x0c Jan 9, 2022 •

edited

Loading

honkmaster commented Feb 7, 2022 •

edited

Loading

4brunu commented Feb 7, 2022 •

edited

Loading