Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin] Added fix for wrongly encoded backticks for reserved words when generating kotlin client #11310

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

knutjda
Copy link
Contributor

@knutjda knutjda commented Jan 13, 2022

Added fix for wrongly encoded backticks for reserved words when generating kotlin client using reserved words as part of the parameters. Wrote a test verifying that the method signatures is without html encoding for backticks

This fixes #11304

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

… with reserved words as part of the parameters. Wrote a test verifying that the method signatures is without html encoding for backticks
Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@wing328 wing328 added this to the 5.4.0 milestone Jan 15, 2022
@wing328 wing328 merged commit 692a4db into OpenAPITools:master Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants