Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] fix Paginated without params (fix #15265) #15315

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

borsch
Copy link
Member

@borsch borsch commented Apr 26, 2023

fix for #15265

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09)

@borsch borsch force-pushed the fix-paginated-without-params branch from 75d8798 to aa0f2fd Compare April 26, 2023 09:06
Copy link
Contributor

@welshm welshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did none of the samples change from this?

@borsch
Copy link
Member Author

borsch commented Apr 26, 2023

Did none of the samples change from this?

@welshm yeah, because our common spec files that are used for generation doesn't have operations with pagination & without parameters

@borsch borsch requested a review from welshm April 26, 2023 15:43
@welshm
Copy link
Contributor

welshm commented Apr 26, 2023

Did none of the samples change from this?

@welshm yeah, because our common spec files that are used for generation doesn't have operations with pagination & without parameters

Should we add a sample? Code change looks good to me otherwise 🚀

@borsch borsch force-pushed the fix-paginated-without-params branch from aa0f2fd to 602a570 Compare April 27, 2023 07:07
@borsch
Copy link
Member Author

borsch commented Apr 27, 2023

Did none of the samples change from this?

@welshm yeah, because our common spec files that are used for generation doesn't have operations with pagination & without parameters

Should we add a sample? Code change looks good to me otherwise 🚀

I've updated samples with one endpoint

@borsch borsch added this to the 6.6.0 milestone Apr 27, 2023
@borsch borsch merged commit 1f23b01 into master Apr 27, 2023
@borsch borsch deleted the fix-paginated-without-params branch April 27, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants