Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][resttemplate] Add property for config removal of @Component from ApiClient and <Name>Api classes #15416

Merged
merged 13 commits into from
May 5, 2023
Merged

[java][resttemplate] Add property for config removal of @Component from ApiClient and <Name>Api classes #15416

merged 13 commits into from
May 5, 2023

Conversation

jorgerod
Copy link
Contributor

@jorgerod jorgerod commented May 4, 2023

Closes: #15136

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@jorgerod jorgerod marked this pull request as ready for review May 4, 2023 11:06
@jorgerod jorgerod changed the title Add property for config removal of @Component from ApiClient and <Name>Api classes [java][resttemplate] Add property for config removal of @Component from ApiClient and <Name>Api classes May 4, 2023
@wing328
Copy link
Member

wing328 commented May 5, 2023

tested locally with the option enabled and the result is good:

[INFO] Building jar: /Users/williamcheng/Code/openapi-generator7/samples/client/petstore/java/resttemplate/target/petstore-resttemplate-1.0.0-javadoc.jar
[INFO] 
[INFO] --- maven-source-plugin:2.2.1:jar-no-fork (attach-sources) @ petstore-resttemplate ---
[INFO] Building jar: /Users/williamcheng/Code/openapi-generator7/samples/client/petstore/java/resttemplate/target/petstore-resttemplate-1.0.0-sources.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  47.777 s
[INFO] Finished at: 2023-05-05T14:18:07+08:00
[INFO] ------------------------------------------------------------------------

Will update the doc (https://github.com/OpenAPITools/openapi-generator/actions/runs/4881966313/jobs/8711603142?pr=15416) after merging this PR.

Thanks for the quick turnaround.

@wing328
Copy link
Member

wing328 commented May 5, 2023

FYI. Filed #15419 to add the option using cliOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA][resttemplate] Removal of @Component from ApiClient and <Name>Api classes is a breaking change
2 participants