-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart-dio] fix endpoints returning null #15433
Conversation
@@ -116,7 +116,7 @@ class {{classname}} { | |||
); | |||
{{#returnType}} | |||
|
|||
{{{returnType}}} _responseData; | |||
{{{.}}}? _responseData; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we know if the response may be null? Maybe we can also change the operation generic return type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it won't matter since the final response.data is nullable anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, that's a dio probelm.
@wing328 @ahmednfwela we should allow developers to define whether they want the response to be nullable or not, data being nullable adds lots of check for the null value. For some usecases, if the data is null, we may want to throw an exception. It should be customisable IMO. Your thoughts? |
having the response nullable suits all cases, and then devs can throw exceptions them selves if the response is null |
Modify mustache files to handle cases where the response data is null (e.g. status code 204) instead of throwing an exception
fixes #15426
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)