Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift6] Add Identifiable conformance to supported models #20166

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

x-sheep
Copy link
Contributor

@x-sheep x-sheep commented Nov 23, 2024

This PR adds a new compiler option (enabled by default) that adds conformance to the Identifiable protocol to models that have an id property of type string, UUID or any integer. Specs can override this per-model by adding the x-swift-identifiable extension.

Resolves #20143

@jgavris @ehyche @Edubits @jaz-ah @4brunu @dydus0x14

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@4brunu
Copy link
Contributor

4brunu commented Nov 24, 2024

Looks good to me 👍
Thanks for the PR.

@4brunu 4brunu merged commit 4c5a57f into OpenAPITools:master Nov 24, 2024
17 checks passed
@x-sheep x-sheep deleted the identifiable branch November 25, 2024 09:30
@wing328 wing328 added this to the 7.11.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [Swift] Add conformance to Identifiable protocol to models when possible
3 participants